Make auto popover list an algorithm #9241
Conversation
Fixes whatwg#9036 This patch also fixes a call to topmost auto popover which was passing an element instead of a document.
If we cached the list by storing it in a variable, I'm worried that it would become out of date in any of the three calls to auto popover list in hide all popovers until |
There was a problem hiding this comment.
It would be great if this could be reviewed by @jakearchibald since he thought the current definition did not quite work.
source
Outdated
| <p>To get the <dfn>auto popover list</dfn> for a <code>Document</code> <var>document</var>:</p> | ||
|
|
||
| <ol> | ||
| <li><p>Let <var>popovers</var> be an empty <span>list</span>.</p></li> |
There was a problem hiding this comment.
I would prefer using list syntax here.
There was a problem hiding this comment.
What is list syntax?
There was a problem hiding this comment.
Let popovers be « ».
There was a problem hiding this comment.
This isn't quite the language I suggested.
There was a problem hiding this comment.
Ok I changed it to exactly "Let popovers be « »."
|
I ended up changing the commit message to lead with the normative change and have the editorial change as a comment in the body. |
Fixes #9036
This patch also fixes a call to topmost auto popover which was passing an element instead of a document.
(See WHATWG Working Mode: Changes for more details.)
/popover.html ( diff )