Add a `prefetch` initiator #659

yoavweiss · 2018-01-08T10:01:13Z

Closes #658

annevk

Happy to land this when the CSP PR is ready.

annevk · 2018-01-15T12:05:20Z

fetch.bs

@@ -917,6 +919,16 @@ not always relevant and might require different behavior.
   <td>"<code>manifest</code>"
   <td><code>manifest-src</code>
   <td>HTML's <code>&lt;link rel=manifest></code>
+  <tr>
+   <td>"<code>prefetch</code>"
+   <td>""


rowspan=2 for this td and the next? And then remove the from the next row?

updated. Let me know if this is what you had in mind

annevk

I guess the only thing that remains here is Akamai signing up. Thanks for working on this!

igrigorik · 2018-01-15T16:06:49Z

fetch.bs

+   <td rowspan=2><code>prefetch-src</code>
+   <td>HTML's <code>&lt;link rel=prefetch></code>
+  <tr>
+   <td>"<code>prerender</code>"


Reading through w3c/webappsec-csp@91adc4a, prefetch-src should also be listed for prerender?

It is (that's what the "rowspan=2" is all about)

Ah, right. Nevermind me, all good!

igrigorik · 2018-01-16T05:48:32Z

Looks great, thanks for driving this Yoav!

yoavweiss · 2018-03-09T11:54:27Z

@annevk - Finally managed to sign the participant agreement on behalf of Akamai. Apologies for the delay. Can you please verify me to appease the bots?

annevk · 2018-03-12T07:02:06Z

Done, though I think @domenic needs to flip some switch to make it propagate (I'm happy to learn how btw).

Are the tests for this web-platform-tests/wpt#9013?

Do we have a follow-up issue for dns-prefetch and such that came up in the issue?

yoavweiss · 2018-03-12T07:16:48Z

Are the tests for this web-platform-tests/wpt#9013?

Yeah. We cannot test the prefetch initiator directly (unlike destination changes), so I guess CSP tests is our best to do that.

Do we have a follow-up issue for dns-prefetch and such that came up in the issue?

I'll try to get to it this week (if I won't, it'll probably be at the end of April, due to travel...)

annevk · 2018-03-12T10:46:50Z

Follow-up is #683. I think we should file browser bugs since CSP doesn't have that as a policy. Then this can land.

Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: whatwg/fetch#658 PR: whatwg/fetch#659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f

yoavweiss · 2018-04-26T14:33:08Z

@mikewest added a bunch of tests to https://github.com/w3c/web-platform-tests/tree/master/content-security-policy/prefetch-src and I just added tests to make sure the destination is "" at web-platform-tests/wpt@b3312d9

@annevk - is that enough to land this? Or are more tests needed?

annevk · 2018-04-26T16:10:33Z

@yoavweiss great, though we already had sufficient tests to land. The one thing lacking here is impl bugs: https://github.com/whatwg/meta/blob/master/MAINTAINERS.md#handling-pull-requests.

wanderview · 2018-04-26T16:16:16Z

The initiator is not exposed on Request, correct? So does implementation here mainly mean something for CSP behavior?

annevk · 2018-04-26T16:17:33Z

Yes.

yoavweiss · 2018-04-26T16:18:22Z

Yeah, implementation means implementing prefetch-src directives and enforcing them (as well as an empty destination for prefetch requests)

yoavweiss · 2018-04-26T16:19:20Z

@wanderview There's already https://bugzilla.mozilla.org/show_bug.cgi?id=1449374 but I'm not sure if it should be converted to an "implement prefetch-src" bug, or marked as a duplicate of one after its creation

wanderview · 2018-04-26T16:20:16Z

@yoavweiss I recommend filing a more clear bug about implementing prefetch-src under Core::DOM:Security.

yoavweiss · 2018-04-26T16:20:36Z

@wanderview on it! :)

yoavweiss · 2018-04-26T16:27:28Z

@wanderview Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1457204 but don't seem to have permissions to change components

yoavweiss · 2018-04-27T08:22:57Z

WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=185070 (even though prefetch is not shipped in Safari atm)

Edge bug: I sent out https://twitter.com/yoavweiss/status/989729796895653888 which people say should work. Alternatively @patrickkettner said he'd open one.

annevk · 2018-04-27T08:36:43Z

Thanks @yoavweiss!

Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: whatwg/fetch#658 PR: whatwg/fetch#659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f Reviewed-on: https://chromium-review.googlesource.com/1029858 Commit-Queue: Yoav Weiss <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Reviewed-by: Yutaka Hirano <[email protected]> Cr-Commit-Position: refs/heads/master@{#554341}

…tonly Automatic update from web-platform-testsAlign Request.destination to spec Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: whatwg/fetch#658 PR: whatwg/fetch#659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f Reviewed-on: https://chromium-review.googlesource.com/1029858 Commit-Queue: Yoav Weiss <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Reviewed-by: Yutaka Hirano <[email protected]> Cr-Commit-Position: refs/heads/master@{#554341} -- wpt-commits: 3c940291e9e8c30e8c7c401426160e3531639403 wpt-pr: 10657

…tonly Automatic update from web-platform-testsAlign Request.destination to spec Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: whatwg/fetch#658 PR: whatwg/fetch#659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f Reviewed-on: https://chromium-review.googlesource.com/1029858 Commit-Queue: Yoav Weiss <yoavyoav.ws> Reviewed-by: Charlie Harrison <csharrisonchromium.org> Reviewed-by: Yutaka Hirano <yhiranochromium.org> Cr-Commit-Position: refs/heads/master{#554341} -- wpt-commits: 3c940291e9e8c30e8c7c401426160e3531639403 wpt-pr: 10657 UltraBlame original commit: b60142c1cc9a01efbb27b591c1828015ffa0a6cb

Add a prefetch initiator

14dc71f

annevk approved these changes Jan 8, 2018

View reviewed changes

annevk mentioned this pull request Jan 11, 2018

Introduce 'prefetch-src'. Closes w3c/webappsec-csp#107. w3c/webappsec-csp#283

Merged

yoavweiss mentioned this pull request Jan 15, 2018

Add initiators for prefetch and prerender whatwg/html#3353

Closed

Add a prerender initiator

e9fec2a

annevk reviewed Jan 15, 2018

View reviewed changes

rowspan=2

1450e14

annevk approved these changes Jan 15, 2018

View reviewed changes

igrigorik reviewed Jan 15, 2018

View reviewed changes

annevk mentioned this pull request Apr 18, 2018

Request.destination for <link rel=prefetch> #658

Closed

chromium-wpt-export-bot mentioned this pull request Apr 26, 2018

Align Request.destination to spec web-platform-tests/wpt#10657

Merged

annevk merged commit d5d0840 into whatwg:master Apr 27, 2018

bakkot mentioned this pull request Mar 18, 2020

prefetch initiator appears to be unused #1008

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a `prefetch` initiator #659

Add a `prefetch` initiator #659

yoavweiss commented Jan 8, 2018 •

edited by pr-preview bot

Loading

annevk left a comment

annevk Jan 15, 2018

yoavweiss Jan 15, 2018

annevk left a comment

igrigorik Jan 15, 2018

yoavweiss Jan 15, 2018

igrigorik Jan 16, 2018

igrigorik commented Jan 16, 2018

yoavweiss commented Mar 9, 2018

annevk commented Mar 12, 2018

yoavweiss commented Mar 12, 2018

annevk commented Mar 12, 2018

yoavweiss commented Apr 26, 2018

annevk commented Apr 26, 2018

wanderview commented Apr 26, 2018

annevk commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

wanderview commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

yoavweiss commented Apr 27, 2018

annevk commented Apr 27, 2018

Add a prefetch initiator #659

Add a prefetch initiator #659

Conversation

yoavweiss commented Jan 8, 2018 • edited by pr-preview bot Loading

annevk left a comment

Choose a reason for hiding this comment

annevk Jan 15, 2018

Choose a reason for hiding this comment

yoavweiss Jan 15, 2018

Choose a reason for hiding this comment

annevk left a comment

Choose a reason for hiding this comment

igrigorik Jan 15, 2018

Choose a reason for hiding this comment

yoavweiss Jan 15, 2018

Choose a reason for hiding this comment

igrigorik Jan 16, 2018

Choose a reason for hiding this comment

igrigorik commented Jan 16, 2018

yoavweiss commented Mar 9, 2018

annevk commented Mar 12, 2018

yoavweiss commented Mar 12, 2018

annevk commented Mar 12, 2018

yoavweiss commented Apr 26, 2018

annevk commented Apr 26, 2018

wanderview commented Apr 26, 2018

annevk commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

wanderview commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

yoavweiss commented Apr 26, 2018

yoavweiss commented Apr 27, 2018

annevk commented Apr 27, 2018

Add a `prefetch` initiator #659

Add a `prefetch` initiator #659

yoavweiss commented Jan 8, 2018 •

edited by pr-preview bot

Loading