Clarify that request.origin cannot be "client" at certain points #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwuelker
force-pushed
the
client-asserts
branch
from
89bef34
to
0bf150f
Compare
3 tasks
annevk
reviewed
Sep 25, 2024
simonwuelker
force-pushed
the
client-asserts
branch
from
0bf150f
to
508a9ec
Compare
annevk
reviewed
Sep 25, 2024
Previously, the code implicitly guaranteed that a requests origin could not be "client" after Step 10 of https://fetch.spec.whatwg.org/#concept-fetch. Other algorithms then simply relied on this fact. This is confusing. Instead, we now explicitly assert that the origin is not client whereever we need it. Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
client-asserts
branch
2 times, most recently
from
62bf823
to
4b23d5e
Compare
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
client-asserts
branch
from
4b23d5e
to
3d97ae0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code implicitly guaranteed that a requests origin could not be "client" after Step 10 of
https://fetch.spec.whatwg.org/#concept-fetch.
Other algorithms then simply relied on this fact. This is confusing. Instead, we now explicitly assert that the origin is not client whereever we need it.
This closes #1773
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff