-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processResponseConsumeBody and opaque responses #1446
Comments
The use of processResponseConsumeBody in script fetching is quite recent and is part of a general slow movement toward updating things to use the new Fetch callbacks. We indeed do not seem to be using it quite correctly. For the more general question, I agree there's not much to be done here besides adding "be careful" wording. E.g., |
If the HTML/CSS specs need to support no-cors fetches, then they also need access to the response body... |
I think there's two things that are wrong here:
#1413 should land first though. |
I noticed today that fetching scripts in HTML uses this and while it currently seemingly ignores the second argument that seems like a bug as the body on which it tries to operate will have been consumed.
However, it might be somewhat surprising we end up revealing the full byte sequence of opaque responses to callers without any kind of ceremony.
Not really sure how to address this other than add some "be careful" words around this.
@noamr @domenic thoughts?
The text was updated successfully, but these errors were encountered: