Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Use RFC 5646 for README and folders name. #246

Open
ByMykel opened this issue Jan 21, 2023 · 3 comments
Open

[Request] Use RFC 5646 for README and folders name. #246

ByMykel opened this issue Jan 21, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ByMykel
Copy link
Contributor

ByMykel commented Jan 21, 2023

I think the standardized nomenclature for languages is not accurate in the README.

The column table "ISO 639-1" is not exactly the wikipedia description of "two-letter codes"
image

And this section says that you intend to use RFC 5646 but is different from this list
image

Request: Use RFC 5646 for README and folders name.

@BeauBouchard BeauBouchard added the enhancement New feature or request label Jan 21, 2023
@BeauBouchard
Copy link
Member

@switchhalt
"Language code different from standardized nomenclature."

@BeauBouchard BeauBouchard changed the title Language code different from standardized nomenclature. [Request] Use RFC 5646 for README and folders name. Jan 21, 2023
@BeauBouchard
Copy link
Member

BeauBouchard commented Jan 21, 2023

@ByMykel Thanks for bringing this up and taking some time to think about it.

And this section says that you intend to use RFC 5646 but is different from this list

actually that section says RFC 5646 is a super set of ISO 639‑2, and how RFC works in its letter combination.
in the document linked there you can read more about it.
image

Also, more importantly , around that screenshot is these two standards which is why we use those RFC standards.

We want to adhere to the Standards for Content-Language and Accept-Language going forward.

image

The column table "ISO 639-1" is not exactly the wikipedia description of "two-letter codes"

very correct, we should fix that 👍 thank you for pointing this out.

We should do a deep dive into making sure we are adhering to standards set-out, please set us know if we deviate from the ISO 639 in anyway.

@switchhalt
Copy link
Collaborator

@BeauBouchard :P its pretty all over the place with the contributions as we started with "2" letters and built on top of that, later adopting the standard of RFC5646; even in the screenshot of the readme tl-fil is reversed format of the filename.

the RFC5646 that is used in most communication for the content-language for eng-us for us is typically en-US like the above screenshot.

@ByMykel Thank you for pointing this out, it allows us to openly discuss this issue, and address a solution.

we want to be backwards compatible so this change will need to accommodate the previous combinations but i agree, we should adhere to whatever the RFC5646 standard is using which also makes it easier for us all to keep from making errors.

I think we should just rename the files to use "RFC5646" from a list, and include the filenames as "RFC5646" objects in the models, should be pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants