update SearchBar into SearchBar2024 #3820
Conversation
|
Hi @ivanko22 thank you for this update to the pull request. You are moving in the right direction. The idea behind creating a new SearchBar2024 component is so we could leave the SearchBar component in place as-is most places in the code, and test SearchBar2024 (and the new lower-level component you created from Storybook) in different contexts. I would ask that you leave this component unchanged: src/js/components/Search/SearchBar.jsx ...and then create a new component src/js/components/Search/SearchBar2024.jsx that includes your new Storybook search input. Note: SearchBar and SearchBar2024 should be interchangeable, so we can compare the two. |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| /> | ||
| <div className="search-bar-options"> | ||
| {(clearButton && searchString && searchString.length > 0) && ( | ||
| <button |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </button> | ||
| )} | ||
| {(searchButton) && ( | ||
| <button |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
|
Hi @DaleMcGrew I change back files with SearchBar and keep SearchBar2024 in Campaign and OneValue. |
|
@DaleMcGrew |
|
Great work @ivanko22! Thank you. 👍 |
What github.com/wevote/WebApp/issues does this fix?
Changes included this pull request?