[WV-166] Fix #3796
Merged
[WV-166] Fix #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….js in order to load header/navbar when loading candidates page outside of the country. Instead of routing to -candidates/cs when out of the country will route to /cs
DaleMcGrew
approved these changes
Dec 13, 2023
| export function isValidStateCode (incomingStateCode) { | ||
| if (incomingStateCode) { | ||
| // Log incoming State Code | ||
| console.log('incomingStateCode:', incomingStateCode); |
There was a problem hiding this comment.
Please comment out console.log's like this in future commits.
There was a problem hiding this comment.
Will do! Sorry about that. I thought I got them all!
ivanko22
pushed a commit
to ivanko22/WebApp
that referenced
this pull request
Dec 17, 2023
* [WV-166] changes made in CampaignsHomeLoader.jsx and addressFunctions.js in order to load header/navbar when loading candidates page outside of the country. Instead of routing to -candidates/cs when out of the country will route to /cs * [WV-166] cleaning up commits etc.
anup2307
pushed a commit
to anup2307/WebApp
that referenced
this pull request
Dec 19, 2023
* [WV-166] changes made in CampaignsHomeLoader.jsx and addressFunctions.js in order to load header/navbar when loading candidates page outside of the country. Instead of routing to -candidates/cs when out of the country will route to /cs * [WV-166] cleaning up commits etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
[WV-166]
Changes included this pull request?
A new function is added to addressFunctions.js made in collaboration with Dale. A new set of conditional operations was added to CampaignsHomeLoader.jsx. With each of these in conjunction, if a stateCode isn't recognized (for example, someone is out of the country) they will then be routed to /cs instead of -candidates/cs. There is not longer an issue with the header not appearing and the expected behavior is happening.