add storybook with buttons #3792
Conversation
|
Thank you @ivanko22 I'm excited to play with this. It looks like you didn't check in (add to your Pull Request) all of the new directories and files you are referencing, including these: |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| // More on writing stories with args: https://storybook.js.org/docs/writing-stories/args | ||
| export const AllButtons = (args) => ( | ||
| <ButtonContainer> | ||
| <Button {...Primary.args} primary size="large" label="Primary Large Disabled Button" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| export const AllButtons = (args) => ( | ||
| <ButtonContainer> | ||
| <Button {...Primary.args} primary size="large" label="Primary Large Disabled Button" /> | ||
| <Button {...Primary.args} primary={false} size="large" label="PrimaryLarge Disabled Button" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <ButtonContainer> | ||
| <Button {...Primary.args} primary size="large" label="Primary Large Disabled Button" /> | ||
| <Button {...Primary.args} primary={false} size="large" label="PrimaryLarge Disabled Button" /> | ||
| <Button {...Primary.args} primary label="Primary Medium Button" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <Button {...Primary.args} primary size="large" label="Primary Large Disabled Button" /> | ||
| <Button {...Primary.args} primary={false} size="large" label="PrimaryLarge Disabled Button" /> | ||
| <Button {...Primary.args} primary label="Primary Medium Button" /> | ||
| <Button {...PrimaryDisabled.args} primary={false} label="Primary Medium Disabled Button" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <Button {...Primary.args} primary={false} size="large" label="PrimaryLarge Disabled Button" /> | ||
| <Button {...Primary.args} primary label="Primary Medium Button" /> | ||
| <Button {...PrimaryDisabled.args} primary={false} label="Primary Medium Disabled Button" /> | ||
| <Button {...Primary.args} primary size="small" label="Primary Small Button" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <Button {...Primary.args} primary label="Primary Medium Button" /> | ||
| <Button {...PrimaryDisabled.args} primary={false} label="Primary Medium Disabled Button" /> | ||
| <Button {...Primary.args} primary size="small" label="Primary Small Button" /> | ||
| <Button {...PrimaryDisabled.args} primary={false} size="small" label="Primary Small Disabled" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </> | ||
| ) : ( | ||
| <> | ||
| <Button size="small" onClick={onLogin} label="Log in" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
|
@DaleMcGrew just added it. Thank You! |
|
👍 |
What github.com/wevote/WebApp/issues does this fix?
Changes included this pull request?