Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong order of onLogs logs types in useWatch***Event if indexed properties are not first #4257

Closed
1 task done
simpsonphile opened this issue Sep 10, 2024 · 2 comments
Closed
1 task done
Labels
Needs Reproduction Misc: Needs Reproduction

Comments

@simpsonphile
Copy link

Check existing issues

Describe the bug

in useWatch***Event onLogs(logs) data is not matching types if indexed values are not first. if some value is indexed it goes before not indexed values and that's when mismatch happen because types not take it into account. example:

  event GameUpdated(
    address indexed player,
    uint256,
    uint8[],
    uint8[],
    GameStatus indexed status,
    uint256
  );

logs[1] is actually GameStatus indexed status but type is still uint256

Link to Minimal Reproducible Example

No response

Steps To Reproduce

No response

What Wagmi package(s) are you using?

wagmi, @wagmi/cli

Wagmi Package(s) Version(s)

2.12.0

Viem Version

2.17.10

TypeScript Version

5.5.2

Anything else?

No response

@jxom jxom added the Needs Reproduction Misc: Needs Reproduction label Sep 10, 2024
Copy link
Contributor

Hello @simpsonphile.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config/environment and issue, and allow us to help you faster.

Once a minimal reproduction is added, a team member will confirm it works, then re-open the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Reproduction Misc: Needs Reproduction
Projects
None yet
Development

No branches or pull requests

2 participants