Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Issue and PR templates #83

Open
westy92 opened this issue Oct 23, 2017 · 0 comments
Open

Add Issue and PR templates #83

westy92 opened this issue Oct 23, 2017 · 0 comments

Comments

@westy92
Copy link
Owner

westy92 commented Oct 23, 2017

Documentation: https://github.com/blog/2111-issue-and-pull-request-templates

Use the following ideas to craft them.

For bugs, we want:

  • platform (Windows 10 x64, Ubuntu x64 16.04, macOS 10.12.1, etc.)
  • Node.js version (6.11.4, 8.7.0, etc.)
  • Chrome/chromium version (61.0.3163.100 (Official Build) (64-bit), etc.)
  • html-pdf-chrome version (0.5.0, etc.)
  • steps to reproduce
  • expected result
  • actual result

For PRs, we want:

  • tests
  • maintain 100% code coverage if possible
  • any appropriate documentation updates
  • no build errors or warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant