Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy/paste config snippet says vad 50% while docs say 85-95% #199

Open
klein-sipgate opened this issue Sep 3, 2024 · 0 comments
Open

copy/paste config snippet says vad 50% while docs say 85-95% #199

klein-sipgate opened this issue Sep 3, 2024 · 0 comments

Comments

@klein-sipgate
Copy link

klein-sipgate commented Sep 3, 2024

The copy/paste snippet provided in the README.md says

"VAD Threshold (%)" = 50.0

at the same time, a few lines below, the document says

In most cases the threshold between 85% - 95% would be fine.

My suggestion would be to change the snippet to 90 (ie avg. of 85 and 95) in order to provide a better experience after initial copy/paste configuration.

diff --git a/README.md b/README.md
index 0e7db10..f5fe468 100644
--- a/README.md
+++ b/README.md
@@ -82,7 +82,7 @@ context.modules = [
                     plugin = /path/to/librnnoise_ladspa.so
                     label = noise_suppressor_mono
                     control = {
-                        "VAD Threshold (%)" = 50.0
+                        "VAD Threshold (%)" = 90.0
                         "VAD Grace Period (ms)" = 200
                         "Retroactive VAD Grace (ms)" = 0
                     }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant