Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reward voice XP to users who are alone in voice chat. #6

Open
weibeu opened this issue Sep 30, 2020 · 0 comments · May be fixed by #16
Open

Do not reward voice XP to users who are alone in voice chat. #6

weibeu opened this issue Sep 30, 2020 · 0 comments · May be fixed by #16

Comments

@weibeu
Copy link
Owner

weibeu commented Sep 30, 2020 •
edited
Loading

https://github.com/thec0sm0s/cosmos-discord-bot/blob/4dc781facbba3c2a2fd5ae40783fffd70b35dfe9/cosmos/galaxies/profile/ascension.py#L56-L98

The commented code is partially correct implementation for this but for some reasons it doesn't works as expected. Some refactorings are needed in this logic.

What I strongly feel is, it will start working fine if the same commented block copied under both of the if cases above. But still I am not sure.

https://github.com/thec0sm0s/cosmos-discord-bot/blob/4dc781facbba3c2a2fd5ae40783fffd70b35dfe9/cosmos/galaxies/profile/models/profiles/guild/experience.py#L31
Also you might wanna adjust the above value for testing period so that you can check if voice XP is increasing or not.
@boy-in-blue boy-in-blue linked a pull request Mar 31, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vc xp fix boy-in-blue/cosmos-discord-bot
1 participant
@weibeu