Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider positioning of UI on profile page #31

Open
kraftner opened this issue Oct 24, 2016 · 3 comments
Open

Reconsider positioning of UI on profile page #31

kraftner opened this issue Oct 24, 2016 · 3 comments
Assignees
Milestone

Comments

@kraftner
Copy link
Member

I am not sure it is reasonable that the Avatar UI on the profile page is on the very top, somewhat hackishly implemented via the all_admin_noticeshook. show_user_profile and edit_user_profile might be more reasonable choices.

Good news: Just switching the hook to one of these two works flawlessly. Once #26 is done this might be an easy fix.

@kraftner kraftner changed the title Reconsider positioning of UI Reconsider positioning of UI on profile page Oct 24, 2016
@kraftner
Copy link
Member Author

Okay I take that "flawlessly" back because using one of those other hooks ends up with nested <form> tags. Maybe this was the reason it was done like this in the first place.

@franz-josef-kaiser
Copy link
Member

@kraftner Yes, that was the reason – which I forgot, but now that you mention it …

Maybe a quick PR with a note for the README? Documenting "design decisions" in the form of a note to our later selfs might not be too stupid. Helped me in some cases with other projects.

@kraftner
Copy link
Member Author

Yeah for now adding this to the docs probably is fine.

But it should still be possible to switch the position, it just means we need to piggyback on the main form instead of rolling our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants