Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Allow tags to be configured via config file #881

Open
mynnx opened this issue Dec 16, 2024 · 1 comment
Open

💡 Allow tags to be configured via config file #881

mynnx opened this issue Dec 16, 2024 · 1 comment
Labels
feature request Feature request

Comments

@mynnx
Copy link

mynnx commented Dec 16, 2024

Suggest an idea for Knip

It's currently possible to combine JSDoc tags with --tags="-knipignore" on the CLI to specify special handling for certain exports, but specifying "tags": ["-knipignore"], in the config file does not effect the same change. It's not documented in the Configuration docs so I don't believe it's a bug, but generally I expect parity between the CLI and the config file for a given tool.

Can we please add configurability for tags via the knip.json file?

(Currently I'm trying to advocate for Knip on my team but there are a select few exports that are controversial to delete, so I'm compromising with JSDoc tags for those exports)

@mynnx mynnx added the feature request Feature request label Dec 16, 2024
@webpro
Copy link
Collaborator

webpro commented Dec 17, 2024

Thanks for the suggestion, I'd welcome a pull request for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants