-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prepend entrypoints instead of append #2699
fix: prepend entrypoints instead of append #2699
Conversation
Tests still need to be written |
this resolves an issue with module federation re webpack#2692
9a623e7
to
95fe365
Compare
Codecov Report
@@ Coverage Diff @@
## master #2699 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 34 34
Lines 1333 1333
Branches 381 381
=======================================
Hits 1250 1250
Misses 81 81
Partials 2 2
Continue to review full report at Codecov.
|
Thanks! |
In my TODO |
Thanks! |
@ScriptedAlchemy Did you test this locally, and did it solve the issue? If so, was it with webpack@5? From my tests, it appears that this does not solve the problem for webpack@5. Webpack 5 seems to not handle entries correctly if they are added on after the compiler is created, regardless of if they are appended or prepended. Basically, if any entry is added onto the entry array, the module that was supposed to be exported will be ignored, and just an empty object will be exported, no matter what has been added to the entry array. I got the same result as described here: #2719 (comment) This may need to be solved on the webpack side, so that entries can be injected after the compiler is created without causing problems. |
Fixed in master, anyway thanks for the PR |
For Bugs and Features; did you add new tests?
this resolves an issue with module federation
re #2692
Motivation / Use-Case
Module Federation will not work with WDS in its current state
Breaking Changes
Additional Info