Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NaN and infinite values for float attributes #800

Open
lisa0314 opened this issue Dec 16, 2024 · 1 comment
Open

Allow NaN and infinite values for float attributes #800

lisa0314 opened this issue Dec 16, 2024 · 1 comment

Comments

@lisa0314
Copy link

This issue was raised in this CL review- https://chromium-review.googlesource.com/c/chromium/src/+/6081404/5..10/third_party/blink/web_tests/external/wpt/webnn/validation_tests/elu.https.any.js#b50.

The current blink IDL uses float alpha while spec defines as double alpha. I suppose both have issues and it should be defined as unrestricted double which supports both infinite and NaN.

@inexorabletash
Copy link
Member

See here and here for past discussion. We settled on not adding unrestricted since we didn't think there were use cases for allowing this class inputs to include infinities and NaNs, and that early error for developers was better.

https://g-issues.chromium.org/issues/382108345 doesn't provide use cases either, it's just pointing out where the impl doesn't match the spec.

Are there use cases, e.g. existing models where ORT Web would generate e.g. elu() calls with Infinities or NaNs? If so, happy to revisit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants