-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPT tests tracker / 2 for remaining ops #338
Comments
Link to #265 |
Operator tolerances:
Earlier ones here: #265 (comment) ¹ "Instance" normalization is really spatial normalization, where the spatial channels are reduced and normalized, while batch and channel remain independent. So pass a list of axes just beyond the leading batch and channel dimensions (starting [update] Phase 3+:
|
@BruceDai can you provide on update on these remaining tests, can we close this issue? |
Hi @anssiko, I'm sorry for not updating this status timely. Please see the above updated table of V1 remaining operations, now except tests for these complex gru/gruCell/lstm/lstmCell operations which are WIP by @fdwr and me , others are almost done (remaining prs were under reviewing or approved). Regarding to V2 transformers operations, they've been already tracked by #485, now there're two remaining prs for constant (fillSequence) and triangular which are discussed on #492 and #494. Thanks a lot for great supports from @fdwr @huningxin @Honry and @mei1127 ! 👍 |
@BruceDai @fdwr much thanks for your work on wpt coverage improvements. I noted this in #240. We are expected to share an update on the wpt coverage by the upcoming CR publication transition expected next month. 100% test coverage is not expected for this transition, but the closer we get the better. |
Since recent gru/gruCell tests and lstm/lstmCell tests landed into WPT, now we have all conformance tests to cover current 78 operators. So I'm going to close this issue. |
Here's process of WPT tests for remaining 20 ops with @fdwr‘s great efforts on these operations tolerances, thanks much @fdwr!
Note: Set l2Pool2d being P3 is due to issue #278.
I synced with @fdwr about tolerance definitions for gru/gruCell and lstm/lstmCell,since they're not operators but more like entire miniature graphs themselves, we need community for some help of defining them, thanks.
The text was updated successfully, but these errors were encountered: