Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal slots to MLOperand, MLActivation and basic algorithms #336

Closed
zolkis opened this issue Feb 1, 2023 · 2 comments
Closed

Add internal slots to MLOperand, MLActivation and basic algorithms #336

zolkis opened this issue Feb 1, 2023 · 2 comments

Comments

@zolkis
Copy link
Collaborator

zolkis commented Feb 1, 2023

In the validation steps for various operations (for instance Batch Norm), the following dependencies/references/algorithms need to be defined (this entry will be kept updated):

  • Internal slots for MLOperand:
    • [[type]] as MLOperandType
    • [[dimensions]] as sequence<unsigned long>
    • [[name]] as string (only for input operands)
    • [[data]] as ArrayBufferView (tensor of given dimensions)
    • [[builder]] the associated MLGraphBuilder
  • Algorithm (or internal slot) to get the rank of the operand (for checking range for axis)
  • Algorithm to internally create an MLOperand given |builder| and |descriptor|, used by op algorithms.
  • Algorithm to internally copy an MLOperand, used by op algorithms.
  • Algorithm to check dimensions given |dimensions| and |type|.
  • Internal slots for MLActivation:
    • [[name]] as string, e.g. "relu", "sigmoid", "softmax", etc.
    • ? [[input]] as MLOperand (needed?)
    • ? [[output]] as MLOperand (intermediate output?)
  • Algorithm to create an MLActivation, used by the op algorithms.

Related to the clarification of terms requested in #335.

@anssiko
Copy link
Member

anssiko commented Jun 22, 2023

@zolkis given PR #400 (comment) was closed please provide a record here of commit(s) and/or PR(s) that address this issue. When done, close this issue.

My recommendation is to link each PR with an issue using the Fix keyword either in the PR description of the commit message to enable the associated issue(s) to be automatically closed upon merge.

@zolkis
Copy link
Collaborator Author

zolkis commented Jun 22, 2023

The content of #400, and previously, #337, has been agreed with @huningxin to be split among the PRs that will have dependencies to this content:
#347, #348, #398 (#366), #365

@zolkis zolkis closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants