From 5660adc55d4a758fcae7236b7ca4e57726aade40 Mon Sep 17 00:00:00 2001
From: dlohvinov <nsblnr@gmail.com>
Date: Tue, 21 May 2024 18:18:19 +0300
Subject: [PATCH] hotfix: removed "remember" checkbox [WTEL-4573]

---
 .../auth/login/steps/the-login-first-step.vue |  4 ++-
 .../login/steps/the-login-second-step.vue     | 31 +++++++------------
 .../steps/the-register-first-step.vue         |  2 ++
 .../steps/the-register-second-step.vue        | 14 ++-------
 src/locale/en/en.js                           |  1 -
 src/locale/ru/ru.js                           |  1 -
 src/locale/ua/ua.js                           |  1 -
 src/store/modules/auth/__tests__/auth.spec.js | 19 ------------
 src/store/modules/auth/auth.js                | 10 ------
 9 files changed, 20 insertions(+), 63 deletions(-)

diff --git a/src/components/auth/login/steps/the-login-first-step.vue b/src/components/auth/login/steps/the-login-first-step.vue
index c1ab961d..6b745621 100644
--- a/src/components/auth/login/steps/the-login-first-step.vue
+++ b/src/components/auth/login/steps/the-login-first-step.vue
@@ -1,8 +1,10 @@
 <template>
   <wt-input
+    name="domain"
     v-model.trim="domain"
     :label="$t('auth.domain')"
     :v="v$.domain"
+    autocomplete
   />
 
   <div class="auth-form-actions">
@@ -23,9 +25,9 @@
 <script setup>
 import { useVuelidate } from '@vuelidate/core';
 import { required } from '@vuelidate/validators';
+import domainValidator from '@webitel/ui-sdk/src/validators/domainValidator';
 import { computed, onMounted } from 'vue';
 import { useStore } from 'vuex';
-import domainValidator from '@webitel/ui-sdk/src/validators/domainValidator';
 import { useNextOnEnter } from '../../../../composables/useNextOnEnter.js';
 
 const props = defineProps({
diff --git a/src/components/auth/login/steps/the-login-second-step.vue b/src/components/auth/login/steps/the-login-second-step.vue
index e28a41a7..4c5e5e5e 100644
--- a/src/components/auth/login/steps/the-login-second-step.vue
+++ b/src/components/auth/login/steps/the-login-second-step.vue
@@ -2,38 +2,35 @@
   <div>
     <div class="auth-form-inner">
       <wt-input
-        :value="domain"
         :label="$t('auth.domain')"
+        :value="domain"
         class="auth-form-inner--domain"
         disabled
       />
 
       <wt-input
+        name="username"
         v-model.trim="username"
         :label="$t('vocabulary.login')"
         :v="v$.username"
+        autocomplete
       />
 
       <wt-input
+        name="password"
         v-model.trim="password"
         :label="$t('auth.password')"
         :v="v$.password"
-        type="password"
+        autocomplete
         has-show-password
-      />
-
-      <wt-checkbox
-        :selected="rememberCredentials"
-        :value="true"
-        :label="$t('auth.remember')"
-        @change="setProp({ prop: 'rememberCredentials', value: $event })"
+        type="password"
       />
     </div>
 
     <div class="auth-form-actions">
       <wt-button
-        @click="emit('back')"
         color="secondary"
+        @click="emit('back')"
       >{{ $t('reusable.back') }}
       </wt-button>
 
@@ -53,25 +50,21 @@ import { useVuelidate } from '@vuelidate/core';
 import { required } from '@vuelidate/validators';
 import { computed, onMounted } from 'vue';
 import { useStore } from 'vuex';
-import LoginProviders from '../providers/the-login-providers.vue';
 import { useNextOnEnter } from '../../../../composables/useNextOnEnter.js';
+import LoginProviders from '../providers/the-login-providers.vue';
 
 const emit = defineEmits(['back', 'next']);
 
 const store = useStore();
-1
+1;
 const domain = computed(() => store.state.auth.domain);
 const username = computed({
   get: () => store.state.auth.username,
-  set: (value) => setProp({ prop: 'username', value })
+  set: (value) => setProp({ prop: 'username', value }),
 });
 const password = computed({
   get: () => store.state.auth.password,
-  set: (value) => setProp({ prop: 'password', value })
-});
-const rememberCredentials = computed({
-  get: () => store.state.auth.rememberCredentials,
-  set: (value) => setProp({ prop: 'rememberCredentials', value })
+  set: (value) => setProp({ prop: 'password', value }),
 });
 
 const v$ = useVuelidate(
@@ -87,7 +80,7 @@ const v$ = useVuelidate(
   { $autoDirty: true },
 );
 
-onMounted(() => { v$.value.$touch() });
+onMounted(() => { v$.value.$touch(); });
 
 useNextOnEnter(() => !v$.value.$invalid && emit('next'));
 
diff --git a/src/components/auth/register/steps/the-register-first-step.vue b/src/components/auth/register/steps/the-register-first-step.vue
index d5c7ae9d..8ea2c3ee 100644
--- a/src/components/auth/register/steps/the-register-first-step.vue
+++ b/src/components/auth/register/steps/the-register-first-step.vue
@@ -1,9 +1,11 @@
 <template>
   <div>
     <wt-input
+      name="domain"
       v-model.trim="domain"
       :label="$t('auth.domain')"
       :v="v$.domain"
+      autocomplete
     />
 
     <div class="auth-form-actions">
diff --git a/src/components/auth/register/steps/the-register-second-step.vue b/src/components/auth/register/steps/the-register-second-step.vue
index 685c2c71..961df1fa 100644
--- a/src/components/auth/register/steps/the-register-second-step.vue
+++ b/src/components/auth/register/steps/the-register-second-step.vue
@@ -2,12 +2,15 @@
   <div>
     <div class="auth-form-inner">
       <wt-input
+        name="username"
         v-model.trim="username"
         :label="$t('vocabulary.login')"
         :v="v$.username"
+        type="username"
       />
 
       <wt-input
+        name="password"
         v-model.trim="password"
         :label="$t('auth.password')"
         :v="v$.password"
@@ -22,13 +25,6 @@
         type="password"
         @keyup.enter="emit('next')"
       />
-
-      <wt-checkbox
-        :selected="rememberCredentials"
-        :value="true"
-        :label="$t('auth.remember')"
-        @change="setProp({ prop: 'rememberCredentials', value: $event })"
-      />
     </div>
 
     <div class="auth-form-actions">
@@ -70,10 +66,6 @@ const confirmPassword = computed({
   get: () => store.state.auth.confirmPassword,
   set: (value) => setProp({ prop: 'confirmPassword', value })
 });
-const rememberCredentials = computed({
-  get: () => store.state.auth.rememberCredentials,
-  set: (value) => setProp({ prop: 'rememberCredentials', value })
-});
 
 const v$ = useVuelidate(
   computed(() => ({
diff --git a/src/locale/en/en.js b/src/locale/en/en.js
index f192ca3f..c5803706 100644
--- a/src/locale/en/en.js
+++ b/src/locale/en/en.js
@@ -15,7 +15,6 @@ export default {
     registerSubmit: 'Register',
     signIn: 'Sign in',
     login: 'Log in',
-    remember: 'Remember',
     code: 'Code',
     enterAuthenticationCode: 'Enter your two-factor authentication code',
     carousel: {
diff --git a/src/locale/ru/ru.js b/src/locale/ru/ru.js
index 842b648f..7ba02e2d 100644
--- a/src/locale/ru/ru.js
+++ b/src/locale/ru/ru.js
@@ -15,7 +15,6 @@ export default {
     registerSubmit: 'Создать',
     signIn: 'Войти',
     login: 'Войти',
-    remember: 'Запомнить',
     code: 'Код',
     enterAuthenticationCode: 'Введите ваш код двухфакторной аутентификации',
   },
diff --git a/src/locale/ua/ua.js b/src/locale/ua/ua.js
index c309e70a..a889e21e 100644
--- a/src/locale/ua/ua.js
+++ b/src/locale/ua/ua.js
@@ -15,7 +15,6 @@ export default {
     registerSubmit: 'Створити',
     signIn: 'Увійти',
     login: 'Увійти',
-    remember: 'Запам\'ятати',
     code: 'Код',
     enterAuthenticationCode: 'Введіть ваш код двофакторної автентифікації',
   },
diff --git a/src/store/modules/auth/__tests__/auth.spec.js b/src/store/modules/auth/__tests__/auth.spec.js
index 93354f23..65547ae7 100644
--- a/src/store/modules/auth/__tests__/auth.spec.js
+++ b/src/store/modules/auth/__tests__/auth.spec.js
@@ -103,7 +103,6 @@ describe('auth store', () => {
   it('CACHE_USER_DATA caches domain by default', async () => {
     const domain = 'domain';
     context.state.domain = domain;
-    context.state.rememberCredentials = false;
 
     const mock = vi.spyOn(localStorage, 'setItem').mockImplementationOnce(vi.fn());
 
@@ -111,24 +110,6 @@ describe('auth store', () => {
     expect(mock).toHaveBeenCalledWith('auth/domain', domain);
   });
 
-  it('CACHE_USER_DATA caches username + password + remCreds, if remCreds is true', async () => {
-    const username = 'vi1';
-    const password = 'vi2';
-
-    context.state = {
-      username,
-      password,
-      rememberCredentials: true,
-    };
-
-    const mock = vi.spyOn(localStorage, 'setItem').mockImplementationOnce(vi.fn());
-
-    await auth.actions.CACHE_USER_DATA(context);
-    expect(mock).toHaveBeenCalledWith('auth/username', username);
-    expect(mock).toHaveBeenCalledWith('auth/password', password);
-    expect(mock).toHaveBeenCalledWith('auth/rememberCredentials', 'true');
-  });
-
   it('CHECK_DOMAIN action calls AuthAPI.checkDomainExistence with domain from state', async () => {
     const domain = 'domain';
     context.state.domain = domain;
diff --git a/src/store/modules/auth/auth.js b/src/store/modules/auth/auth.js
index c7d3d52f..ce5d768f 100644
--- a/src/store/modules/auth/auth.js
+++ b/src/store/modules/auth/auth.js
@@ -12,7 +12,6 @@ const defaultState = () => ({
 
 const state = {
   ...defaultState(),
-  rememberCredentials: localStorage.getItem('auth/rememberCredentials') === 'true',
   loginProviders: {},
   enabledTfa: false,
   totp: '',
@@ -117,15 +116,6 @@ const actions = {
 
   CACHE_USER_DATA: (context) => {
     if (context.state.domain) localStorage.setItem('auth/domain', context.state.domain);
-    if (context.state.rememberCredentials) {
-      if (context.state.username) localStorage.setItem('auth/username', context.state.username);
-      if (context.state.password) localStorage.setItem('auth/password', context.state.password);
-      localStorage.setItem('auth/rememberCredentials', 'true');
-    } else {
-      localStorage.removeItem('auth/username');
-      localStorage.removeItem('auth/password');
-      localStorage.removeItem('auth/rememberCredentials');
-    }
   },
 
   CHECK_DOMAIN: (context, domain = context.state.domain) => {