From 78ff450f74cf9b45649c68e30cf56049acb4b37a Mon Sep 17 00:00:00 2001
From: lizacoma <my.skin00@gmail.com>
Date: Fri, 1 Mar 2024 14:41:53 +0200
Subject: [PATCH 1/2] fix: contact communication popup [WTEL-3883]

---
 src/app/locale/en/en.js                               |  6 ++++--
 src/app/locale/ru/ru.js                               |  6 ++++--
 src/app/locale/ua/ua.js                               |  6 ++++--
 .../components/opened-contact-communication-popup.vue | 11 +++++------
 4 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/src/app/locale/en/en.js b/src/app/locale/en/en.js
index 9801d95d..4a85e1f6 100644
--- a/src/app/locale/en/en.js
+++ b/src/app/locale/en/en.js
@@ -16,11 +16,13 @@ export default {
       destination: 'Destination',
       setAsPrimary: 'Set as primary',
       emails: {
-        title: 'The email',
+        addTitle: 'Add the email',
+        editTitle: 'Edit the email',
         dummy: 'There are no email addresses yet',
       },
       phones: {
-        title: 'The phone number',
+        addTitle: 'Add the phone number',
+        editTitle: 'Edit the phone number',
         dummy: 'There are no phone numbers yet',
       },
     },
diff --git a/src/app/locale/ru/ru.js b/src/app/locale/ru/ru.js
index 9474a137..653875b3 100644
--- a/src/app/locale/ru/ru.js
+++ b/src/app/locale/ru/ru.js
@@ -16,11 +16,13 @@ export default {
       destination: 'Назначение',
       setAsPrimary: 'Установить как основной',
       emails: {
-        title: 'Электронный адрес',
+        addTitle: 'Добавить електронный адрес',
+        editTitle: 'Редактировать електронный адрес',
         dummy: 'Электронные адреса еще не добавлены',
       },
       phones: {
-        title: 'Номер телефона',
+        addTitle: 'Добавить номер телефона',
+        editTitle: 'Редактировать номер телефона',
         dummy: 'Телефонные номера еще не добавлены',
       },
     },
diff --git a/src/app/locale/ua/ua.js b/src/app/locale/ua/ua.js
index b9100630..010cbb27 100644
--- a/src/app/locale/ua/ua.js
+++ b/src/app/locale/ua/ua.js
@@ -16,11 +16,13 @@ export default {
       destination: 'Призначення',
       setAsPrimary: 'Встановити як основний',
       emails: {
-        title: 'Електронна адреса',
+        addTitle: 'Додати електронну адресу',
+        editTitle: 'Редагувати електронну адресу',
         dummy: 'Електронні адреси ще не додано',
       },
       phones: {
-        title: 'Номер телефону',
+        addTitle: 'Додати номер телефону',
+        editTitle: 'Редагувати номер телефону',
         dummy: 'Телефонні номери ще не додано',
       },
     },
diff --git a/src/modules/contacts/components/opened-contact-communication-popup.vue b/src/modules/contacts/components/opened-contact-communication-popup.vue
index a3fe3f6a..781022e4 100644
--- a/src/modules/contacts/components/opened-contact-communication-popup.vue
+++ b/src/modules/contacts/components/opened-contact-communication-popup.vue
@@ -6,10 +6,7 @@
     @close="close"
   >
     <template #header>
-      {{ item ? t('reusable.edit') : t('reusable.add') }}
-      {{ currentCommunication.locale.toLowerCase() ||
-        t('contacts.communications.communications', 1).toLowerCase()
-      }}
+      {{ item ? currentCommunication.updateLocale : currentCommunication.addLocale }}
     </template>
     <template #main>
       <form
@@ -88,14 +85,16 @@ const TypeSelect = ref(null);
 const communicationOptions = [
   {
     value: 'email', // should be same as backend field for destination
-    locale: t('contacts.communications.emails.title'),
+    addLocale: t('contacts.communications.emails.addTitle'),
+    updateLocale: t('contacts.communications.emails.editTitle'),
     filterField: EngineCommunicationChannels.Email,
     addNamespace: `${props.namespace}/ADD_EMAIL`,
     updateNamespace: `${props.namespace}/UPDATE_EMAIL`,
   },
   {
     value: 'number',
-    locale: t('contacts.communications.phones.title'),
+    addLocale: t('contacts.communications.phones.addTitle'),
+    updateLocale: t('contacts.communications.phones.editTitle'),
     filterField: EngineCommunicationChannels.Phone,
     addNamespace: `${props.namespace}/ADD_PHONE`,
     updateNamespace: `${props.namespace}/UPDATE_PHONE`,

From 2e5e798ca61b046bc57037cfae139c39048e39e6 Mon Sep 17 00:00:00 2001
From: lizacoma <my.skin00@gmail.com>
Date: Fri, 1 Mar 2024 17:13:18 +0200
Subject: [PATCH 2/2] fix: small refactoring after review [WTEL-3883]

---
 .../opened-contact-communication-popup.vue           | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/modules/contacts/components/opened-contact-communication-popup.vue b/src/modules/contacts/components/opened-contact-communication-popup.vue
index 781022e4..940ea073 100644
--- a/src/modules/contacts/components/opened-contact-communication-popup.vue
+++ b/src/modules/contacts/components/opened-contact-communication-popup.vue
@@ -6,7 +6,7 @@
     @close="close"
   >
     <template #header>
-      {{ item ? currentCommunication.updateLocale : currentCommunication.addLocale }}
+      {{ item ? currentCommunication.updateText : currentCommunication.addText }}
     </template>
     <template #main>
       <form
@@ -85,23 +85,23 @@ const TypeSelect = ref(null);
 const communicationOptions = [
   {
     value: 'email', // should be same as backend field for destination
-    addLocale: t('contacts.communications.emails.addTitle'),
-    updateLocale: t('contacts.communications.emails.editTitle'),
+    addText: t('contacts.communications.emails.addTitle'),
+    updateText: t('contacts.communications.emails.editTitle'),
     filterField: EngineCommunicationChannels.Email,
     addNamespace: `${props.namespace}/ADD_EMAIL`,
     updateNamespace: `${props.namespace}/UPDATE_EMAIL`,
   },
   {
     value: 'number',
-    addLocale: t('contacts.communications.phones.addTitle'),
-    updateLocale: t('contacts.communications.phones.editTitle'),
+    addText: t('contacts.communications.phones.addTitle'),
+    updateText: t('contacts.communications.phones.editTitle'),
     filterField: EngineCommunicationChannels.Phone,
     addNamespace: `${props.namespace}/ADD_PHONE`,
     updateNamespace: `${props.namespace}/UPDATE_PHONE`,
   },
   // {
   //   value: 'messaging',
-  //   locale: ,
+  //   text: ,
   //   filterField: EngineCommunicationChannels.Messaging,
   //   namespace: ,
   // },