From 3a60dda01e0f5713f3915ed25077fc8e300cdc8f Mon Sep 17 00:00:00 2001 From: liza-pohranichna Date: Mon, 1 Jul 2024 00:46:04 +0300 Subject: [PATCH 1/6] feature: changed styles for settings and added new call-end-sound block [WTEL-4668] --- src/app/locale/en/en.js | 1 + src/app/locale/ru/ru.js | 1 + src/app/locale/ua/ua.js | 1 + .../settings/components/the-settings.vue | 44 ++++++++++++++++++- 4 files changed, 45 insertions(+), 2 deletions(-) diff --git a/src/app/locale/en/en.js b/src/app/locale/en/en.js index fdc2061de..7d54bf8a2 100644 --- a/src/app/locale/en/en.js +++ b/src/app/locale/en/en.js @@ -59,6 +59,7 @@ export default { webPhone: 'WebPhone', useWebPhone: 'Use WebPhone', useStun: 'Use STUN', + callEnd: 'Call end tune infroming', }, validation: { diff --git a/src/app/locale/ru/ru.js b/src/app/locale/ru/ru.js index 8797fb481..f048c947d 100644 --- a/src/app/locale/ru/ru.js +++ b/src/app/locale/ru/ru.js @@ -59,6 +59,7 @@ export default { webPhone: 'Web-телефон', useWebPhone: 'Использовать Web-телефон', useStun: 'Использовать STUN', + callEnd: 'Звуковое оповещение про завершение звонка', }, validation: { diff --git a/src/app/locale/ua/ua.js b/src/app/locale/ua/ua.js index 2009d936f..278974f60 100644 --- a/src/app/locale/ua/ua.js +++ b/src/app/locale/ua/ua.js @@ -59,6 +59,7 @@ export default { webPhone: 'Web-телефон', useWebPhone: 'Використовувати Web-телефон', useStun: 'Використовувати STUN', + callEnd: 'Звукове сповіщення про завершення дзвінка', }, validation: { diff --git a/src/modules/settings/components/the-settings.vue b/src/modules/settings/components/the-settings.vue index ed28a17e7..1b635ce4d 100644 --- a/src/modules/settings/components/the-settings.vue +++ b/src/modules/settings/components/the-settings.vue @@ -82,6 +82,22 @@ +
+
+

+ {{ $t('settings.callEnd') }} +

+
+
+
+

{{ $t('objects.status') }}

+ +
+
+
@@ -107,6 +123,7 @@ export default { isPasswordPatching: false, webrtc: true, stun: false, + callEndSound: false, language: { name: 'English', id: 'en', @@ -209,6 +226,13 @@ export default { } }, + changeCallEndSoundState(value) { + value + ? localStorage.setItem('callEndSound', 'true') + : localStorage.removeItem('callEndSound'); + this.callEndSound = value; + }, + changeLanguage(value) { localStorage.setItem('lang', value.id); this.language = value; @@ -227,11 +251,27 @@ export default { From 8161a2b54dc94d894f7105d6dab5916eb7745074 Mon Sep 17 00:00:00 2001 From: liza-pohranichna Date: Mon, 1 Jul 2024 12:28:25 +0300 Subject: [PATCH 2/6] feature: added restore call end sound [WTEL-4668] --- src/modules/settings/components/the-settings.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/settings/components/the-settings.vue b/src/modules/settings/components/the-settings.vue index 1b635ce4d..6a795a2a2 100644 --- a/src/modules/settings/components/the-settings.vue +++ b/src/modules/settings/components/the-settings.vue @@ -164,6 +164,7 @@ export default { created() { this.restoreLanguage(); + this.callEndSound = !!localStorage.getItem('callEndSound'); }, computed: { From e356fcb2b909934c6aa91f31705a16a9afc84d60 Mon Sep 17 00:00:00 2001 From: liza-pohranichna Date: Tue, 2 Jul 2024 15:56:49 +0300 Subject: [PATCH 3/6] feature: after review [WTEL-4668] --- src/modules/settings/components/the-settings.vue | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/modules/settings/components/the-settings.vue b/src/modules/settings/components/the-settings.vue index 6a795a2a2..6ce66ba35 100644 --- a/src/modules/settings/components/the-settings.vue +++ b/src/modules/settings/components/the-settings.vue @@ -260,10 +260,6 @@ export default { min-width: 200px; gap: var(--spacing-sm); - //.content-title { - // @extend %typo-subtitle-1; - //} - &__setting { width: 50%; display: flex; From 667dafbe2f4280b49cf69a76d0f725d44a287c30 Mon Sep 17 00:00:00 2001 From: liza-pohranichna Date: Fri, 5 Jul 2024 22:02:23 +0300 Subject: [PATCH 4/6] feature: changes after review [WTEL-4668] --- src/modules/settings/components/the-settings.vue | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/modules/settings/components/the-settings.vue b/src/modules/settings/components/the-settings.vue index 6ce66ba35..bcb78eb42 100644 --- a/src/modules/settings/components/the-settings.vue +++ b/src/modules/settings/components/the-settings.vue @@ -92,7 +92,7 @@

{{ $t('objects.status') }}

@@ -123,7 +123,7 @@ export default { isPasswordPatching: false, webrtc: true, stun: false, - callEndSound: false, + callEndSound: !!localStorage.getItem('callEndSound'), language: { name: 'English', id: 'en', @@ -164,7 +164,6 @@ export default { created() { this.restoreLanguage(); - this.callEndSound = !!localStorage.getItem('callEndSound'); }, computed: { @@ -251,8 +250,9 @@ export default {