Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] hint shouldn't warn about forceConsistentCasingInFileNames when TS version is >= 5.0.0 #5880

Open
hamirmahal opened this issue Jun 27, 2024 · 6 comments
Assignees
Labels

Comments

@hamirmahal
Copy link

🐞 Bug report

Description

hint shouldn't warn about forceConsistentCasingInFileNames when the TypeScript version is >= 5.0.0.

Details

forceConsistentCasingInFileNames defaults to true for TypeScript versions >= 5.0.0.

@hamirmahal
Copy link
Author

@hamirmahal
Copy link
Author

image

@vidorteg
Copy link
Member

Hi @hamirmahal,

Thank you for the report, do you have a minimal repro or example on where are you observing this behavior and also how that differs to your expected output, it would be better if no images are provided as I cannot copy/paste from them. Where are you adding this compilerOptions option?

@hamirmahal
Copy link
Author

Hello @vidorteg,

You're welcome. An otherwise empty repository with this tsconfig.json reproduces the error.

{
  "compilerOptions": { <- webhint says `forceConsistentCasingInFileNames` should be `true`
    "strict": true
  }
}

I'm adding the compilerOptions option to tsconfig.json.

webhint gives a

The compiler option "forceConsistentCasingInFileNames" should be enabled to reduce issues when working with different OSes.webhinttypescript-config/consistent-casing

warning, but it doesn't need to. forceConsistentCasingInFileNames defaults to true for TypeScript versions >= 5.0.0.

@vidorteg
Copy link
Member

this is extremely helpful, thank you @hamirmahal, will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants