Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): dispatch new version also on new release event #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maloun96
Copy link
Contributor

@maloun96 maloun96 commented May 18, 2021

After some investigation, the "chore" release does not trigger events (https://github.com/webex/components/actions/workflows/dispatch-new-version-event.yml) Here are the latest triggered events and there is no commit with "chore". This PR is going to fix it.

@@ -17,6 +19,9 @@ jobs:
git checkout HEAD~1
PREVIOUS_VERSION=$(node -p -e "require('./package.json').version")

echo "Previous version: $PREVIOUS_VERSION"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this logs to see if it passed and the trigger happens

@maloun96 maloun96 marked this pull request as ready for review May 18, 2021 13:46
@maloun96 maloun96 requested a review from a team as a code owner May 18, 2021 13:46
@maloun96 maloun96 force-pushed the release_workflow branch 3 times, most recently from a243e39 to dbca2da Compare May 18, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant