Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty bedges shouldn't generate Error #42

Open
xoac opened this issue Feb 5, 2020 · 2 comments · May be fixed by #43
Open

Empty bedges shouldn't generate Error #42

xoac opened this issue Feb 5, 2020 · 2 comments · May be fixed by #43

Comments

@xoac
Copy link
Contributor

xoac commented Feb 5, 2020

Is there a reason for README.tpl that contains:

{{badges}}

generate error:

Error: `{{badges}}` was found in template but no badges were provided

It's ok to have no badges in my opinion and this shouldn't be error. At least warning.

@xoac xoac linked a pull request Feb 5, 2020 that will close this issue
@chrysn
Copy link

chrysn commented Sep 22, 2020

I'm not sure that a --force flag is the right way to go here. The transition from using the built-in template to copying the template in README should be a smooth one, and things should run the same way no matter whether the template is explicit or implicit.

@xoac
Copy link
Contributor Author

xoac commented Sep 23, 2020

I agrre with you. This should be warrning not error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants