Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing default value for count in waitForElement #149

Open
htho opened this issue Nov 28, 2024 · 0 comments
Open

Missing default value for count in waitForElement #149

htho opened this issue Nov 28, 2024 · 0 comments

Comments

@htho
Copy link

htho commented Nov 28, 2024

When there is no count property in waitForElement the output contains undefined.

Given an input like this:

{
    "type": "waitForElement",
    "target": "main",
    "selectors": [
        "#counter"
    ],
    "operator": "=="
}

The result is:

await expect(browser.$$("#counter")).toBeElementsArrayOfSize(undefined)

Although the reference does not mention a default value for count, puppeteer-replay assumes a default value of 1. Chromes replay also assumes a default value of 1.

The actual result should be:

await expect(browser.$$("#counter")).toBeElementsArrayOfSize(1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant