Enable promise rejection event tests in ShadowRealm #49341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test files all execute the same tests in different global scopes. We can remove the boilerplate and just combine them all into an .any.js file to achieve the same result.
Task queuing mechanisms based on setTimeout(), postMessage(), and createImageBitmap() are not universally exposed. Split this test into two files, one that uses only universally exposed APIs, and one that does not. Move the helper functions common to both files, into a support file.
promise-rejection-events.any.js tests several combinations of microtask queueing with postMessage, MutationObserver, and Promise.resolve().then(). Add queueMicrotask to this mix, and put it in promise-rejection-events-universal.any.js since it is available universally. Not sure if the section "Positive unhandledrejection/rejectionhandled tests with delayed attachment" is relevant, as there is no way to queue a "macrotask" inside ShadowRealm, so it might not be possible to test the case where it's too late to attach a handler.
These seem OK to run in dedicated workers as well.
This is based on promise-rejection-events-onerror.html but without using "DOM manipulation task source" to queue a task.
ptomato
force-pushed
the
shadowrealm-promise-rejection-event
branch
from
73d403b
to
fc6a598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PromiseRejectionEvent, onunhandledrejection, and onrejectionhandled should be tested in ShadowRealm scopes. This requires shuffling around some existing tests, and writing a few new ones.