Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Request.destination to spec #10657

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 26, 2018

Currently Request.destination is set to "unknown" prefetch,
but that was recently changed:
Issue: whatwg/fetch#658
PR: whatwg/fetch#659

This CL aligns the destination values to the spec change.

Bug: 832105
Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f
Reviewed-on: https://chromium-review.googlesource.com/1029858
Commit-Queue: Yoav Weiss [email protected]
Reviewed-by: Charlie Harrison [email protected]
Reviewed-by: Yutaka Hirano [email protected]
Cr-Commit-Position: refs/heads/master@{#554341}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1029858 branch 2 times, most recently from 6e99a0c to b3312d9 Compare April 26, 2018 14:29
Currently `Request.destination` is set to "unknown" prefetch,
but that was recently changed:
Issue: whatwg/fetch#658
PR: whatwg/fetch#659

This CL aligns the destination values to the spec change.

Bug: 832105
Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f
Reviewed-on: https://chromium-review.googlesource.com/1029858
Commit-Queue: Yoav Weiss <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#554341}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3c94029 into master Apr 27, 2018
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1029858 branch April 27, 2018 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants