Failing in all browsers test in dom/nodes/Element-matches.html

[domenic]

In-document Element.matches: Universal selector, matching all descendants of the specified reference element (with refNode Element): * in https://wpt.fyi/results/dom/nodes/Element-matches.html seems suspicious.

[domenic]

Same problem with the sibling file, Element-webkitMatchesSelector.html

[foolip]

Source is here:

wpt/dom/nodes/selectors.js

Line 442 in 91d7e29

{name: "Universal selector, matching all descendants of the specified reference element", selector: "*", ctx: "#universal", expect: ["universal-p1", "universal-code1", "universal-hr1", "universal-pre1", "universal-span1",

This was last touched by @Ms2ger in 6ceec43, ages ago.

[foolip]

Actually, it's

wpt/dom/nodes/selectors.js

Line 451 in ccd3580

{name: "Universal selector, matching all descendants of the specified reference element", selector: "*", ctx: "#universal", expect: ["universal-p1", "universal-code1", "universal-hr1", "universal-pre1", "universal-span1",

Don't know how I ended up at that older commit through the GitHub UI...

[Ms2ger]

Possibly related: #1577

This is more of a Selectors test; cc @tabatkins @fantasai

[foolip]

A problem I noticed trying to debug this is that selectors.js is written as if element.matches can still take more than one argument, with this bit of comment:

 * expect.matches(selector, context)    // Only where refNodes is not specified
 * expect.matches(selector, refNodes)
 * expect.matches(selector)             // Only if neither context nor refNodes is specified

And it's written to test find() and findAll(), which never came to be.

[foolip]

Those APIs turned into query() and queryAll(), now tracked in whatwg/dom#586 and commented out in the spec.