From baad8ae12b2400c433c9f4d2c760878d8011f184 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Fri, 31 May 2024 18:57:33 -0700 Subject: [PATCH] Make showPicker() consume user activation Allowing the page to call showPicker() on select elements as much as it wants without consuming user activation may result in the user being unable to interact with the browser UI due to popups always taking focus. The HTML spec also says to do this for input elements, so I added code to do it there as well. This patch also modified the select showPicker test because calling showPicker on a select twice in a row in the test somehow resulted in blink not seeing any input events on the second test_driver.bless(), perhaps because the select's popup is still open and is somehow intercepting the input. HTML spec: https://github.com/whatwg/html/pull/10344 Bug: 1521345 Fixed: 343302069, 343093082, 343473478 Change-Id: If6308a67bac9050f695d18d275ea86c23ac22b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235516 Commit-Queue: Joey Arhar Reviewed-by: Di Zhang Cr-Commit-Position: refs/heads/main@{#1309009} --- .../show-picker-user-gesture.html | 28 ++++++++----------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/html/semantics/forms/the-select-element/show-picker-user-gesture.html b/html/semantics/forms/the-select-element/show-picker-user-gesture.html index cab0104f1e28c04..7a9d88cb1c33eea 100644 --- a/html/semantics/forms/the-select-element/show-picker-user-gesture.html +++ b/html/semantics/forms/the-select-element/show-picker-user-gesture.html @@ -5,31 +5,27 @@ - + + +