Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test driver to use computedrole/computedlabel from webdriver #5

Closed
cookiecrook opened this issue Mar 1, 2023 · 1 comment · Fixed by web-platform-tests/wpt#38758

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Mar 1, 2023

@boazsender wrote:

let's go forward with option 2.

…from Issue #2

  1. Use WebDriver

This approach would include adding the new webdriver APIs for things like Get Computed Role to testdriver.js. Computed role is implemented in chrome and safari driver, but not yet in gecko. So we'd need to make a gecko driver patch for this to work.

@cookiecrook
Copy link
Collaborator Author

I'll have a PR for this soon, probably tomorrow.

cookiecrook added a commit to cookiecrook/wpt that referenced this issue Mar 1, 2023
Closes web-platform-tests/interop-accessibility#5

Includes basic explicit and implcit role/label tests each for accname (in /accname) and aria role computation (in /aria/role)
@cookiecrook cookiecrook changed the title Update test driver to use conputedrole/computedlabel from webdriver Update test driver to use computedrole/computedlabel from webdriver Mar 1, 2023
gsnedders pushed a commit to web-platform-tests/wpt that referenced this issue Mar 6, 2023
Closes web-platform-tests/interop-accessibility#5

Includes basic explicit and implcit role/label tests each for accname (in /accname) and aria role computation (in /aria/role)
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 9, 2023
…e/computedlabel, a=testonly

Automatic update from web-platform-tests
Update testdriver to support computedrole/computedlabel (#38758)

Closes web-platform-tests/interop-accessibility#5

Includes basic explicit and implcit role/label tests each for accname (in /accname) and aria role computation (in /aria/role)
--

wpt-commits: 790bb1a2ce2d99442f2e72054dd090a4b5b9c29c
wpt-pr: 38758
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2023
Closes web-platform-tests/interop-accessibility#5

Includes basic explicit and implcit role/label tests each for accname (in /accname) and aria role computation (in /aria/role)
aosmond pushed a commit to aosmond/gecko that referenced this issue May 18, 2023
…e/computedlabel, a=testonly

Automatic update from web-platform-tests
Update testdriver to support computedrole/computedlabel (#38758)

Closes web-platform-tests/interop-accessibility#5

Includes basic explicit and implcit role/label tests each for accname (in /accname) and aria role computation (in /aria/role)
--

wpt-commits: 790bb1a2ce2d99442f2e72054dd090a4b5b9c29c
wpt-pr: 38758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant