Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect if a line is within a multi-line comment block #34

Open
lingyuncai opened this issue Nov 7, 2023 · 0 comments
Open

Detect if a line is within a multi-line comment block #34

lingyuncai opened this issue Nov 7, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@lingyuncai
Copy link
Contributor

The detection is used multiple times in our codebase, and we could improve the detection for lines within a multi-line comment block. See examples below:

https://github.com/intel/webinizer/blob/f6c375223d2e80fff7e6bd8191fb0d2871ef31ef/src/advisors/cpp_exception.ts#L52-L57
@lingyuncai lingyuncai added the good first issue Good for newcomers label Nov 7, 2023
This was referenced Nov 9, 2023
Merged
Closed
amitrahman1026 added a commit to amitrahman1026/webinizer that referenced this issue Nov 9, 2023
@amitrahman1026
Detect multi-line comment block (web-devkits#34)
5878901 
Signed-off-by: amitrahman1026 <[email protected]>
amitrahman1026 added a commit to amitrahman1026/webinizer that referenced this issue Nov 9, 2023
@amitrahman1026
Detect multi-line comment block (web-devkits#34)
8e06255 
Signed-off-by: amitrahman1026 <[email protected]>
amitrahman1026 added a commit to amitrahman1026/webinizer that referenced this issue Nov 9, 2023
@amitrahman1026
Detect multi-line comment block (web-devkits#34)
f940528 
Signed-off-by: amitrahman1026 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lingyuncai