Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for native fallback #125

Closed
alancutter opened this issue Apr 14, 2017 · 1 comment · Fixed by #127
Closed

Add test coverage for native fallback #125

alancutter opened this issue Apr 14, 2017 · 1 comment · Fixed by #127

Comments

@alancutter
Copy link
Contributor

alancutter commented Apr 14, 2017

We currently test using the *.dev.js versions of the polyfill. These do not include native fallback logic and as a consequence bugs relating to native fallback persist undetected until they are hit by users in the next release.
See: #123

@alancutter
Copy link
Contributor Author

I made an error here, we currently run the web-platform-tests suite with the fallback disabled by manually hiding the native implementation:
https://github.com/web-animations/web-animations-js/blob/dev/test/resources/testharnessreport.js#L412

The *.dev.js versions of the polyfill are not used for automated testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant