Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RBAC #1388

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Support RBAC #1388

wants to merge 34 commits into from

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Nov 4, 2024 •
edited by dirkkul
Loading

Closes #1389

@tsmith023 tsmith023 changed the title Add initial skeleton of API structure with pseudo-code test usage Support RBAC Nov 4, 2024
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.65775% with 53 lines in your changes missing coverage. Please review.

Project coverage is 93.75%. Comparing base (6bc9b39) to head (c276c85).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/rbac/roles.py 44.11% 38 Missing ⚠️
integration/test_rbac.py 46.15% 7 Missing ⚠️
weaviate/rbac/models.py 94.44% 4 Missing ⚠️
weaviate/rbac/permissions.py 82.60% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
- Coverage   93.94%   93.75%   -0.20%     
==========================================
  Files         221      226       +5     
  Lines       21283    21468     +185     
==========================================
+ Hits        19995    20127     +132     
- Misses       1288     1341      +53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tsmith023 and others added 20 commits November 5, 2024 16:40
@tsmith023
Add back CI test that fails due to known issue
6998a98
@tsmith023
Reallign actions with new server impl
3f7ab4e
@tsmith023
Update CI to use functional image
d239bfe
@tsmith023
Merge branch 'main' of https://github.com/weaviate/weaviate-python-cl…
0af7fba 
…ient into 1.28/add-support-for-rbac
@tsmith023
Change to correct ports for CI
ed526c4
@tsmith023
Update CI images
37ab8fc
@tsmith023
Skip rbac test if not supported
2e9b229
@dirkkul
Adapt role names plural
d99b520
@tsmith023
Refactor connection removing level from internal Permissions object
abf3d8e
@tsmith023
Merge branch '1.28/add-support-for-rbac' of https://github.com/weavia…
b822e94 
…te/weaviate-python-client into rbac/reallign-with-new-server-api
@tsmith023
Use / instead of ;; in collection-tenant resources string
51de75b
@dirkkul
Merge pull request #1397 from weaviate/rbac/reallign-with-new-server-api
aa25b17 
Refactor connection removing `level` from internal Permissions object
@dirkkul
Adapt to simplified rbac permissions
60d6829
@dirkkul
Merge pull request #1398 from weaviate/adapt_to_simplified_permissions
0b90206 
Adapt to simplified rbac permissions
@dirkkul
Adapt to changes in schema resources
002ea00
@dirkkul
Merge pull request #1405 from weaviate/adapt_schema_changes
8a7b873 
Adapt to changes in schema resources
@dirkkul
Move *_collection actions to Collection
16814ca
@dirkkul
Really fix test
42dc0a9
@dirkkul
Update CI image
92fed33
@dirkkul
really really fix test
ce286d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RBAC support to python client
5 participants
@tsmith023 @weaviate-git-bot @codecov-commenter @dirkkul @moogacs