Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tenant input validations in different Python versions #1355

Open
tsmith023 opened this issue Oct 21, 2024 · 0 comments
Open

Fix flaky tenant input validations in different Python versions #1355

tsmith023 opened this issue Oct 21, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tsmith023
Copy link
Contributor

In Python3.12, it is certain that the logic used when validating the inputs for tenant CRUD methods can flake perhaps due to how Python performs these typing validations under-the-hood. This may be indicative of a bug in Python but we should fix it by avoiding this flaky behaviour:

"""
weaviate.exceptions.WeaviateInvalidInputError: Invalid input provided: Argument 'tenants' must be one of:
[
  <class 'weaviate.collections.classes.tenants.Tenant'>,
  <class 'weaviate.collections.classes.tenants.TenantUpdate'>,
  typing.Sequence[
      typing.Union[weaviate.collections.classes.tenants.Tenant,
      weaviate.collections.classes.tenants.TenantUpdate]
    ]
], but got <class 'list'>.
"""
@tsmith023 tsmith023 added bug Something isn't working good first issue Good for newcomers labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant