Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on protolinting for snake_case #4134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Turn on protolinting for snake_case #4134

wants to merge 2 commits into from
+871 −866

Conversation

foot
Copy link
Contributor

@foot foot commented Nov 15, 2023 •
edited
Loading

Breaks out part of #4005 into a small chunk

What changed?

  • Turn on FIELD_NAMES_LOWER_SNAKE_CASE linting
  • Fix up field names so they are all lower case

Why was this change made?

Field names now conform to the snake case style guide we want to follow https://protobuf.dev/programming-guides/style/

How was this change implemented?

Using the -fix flag in the command: protolint lint -fix -config_path=.protolint.yaml ./api

How did you validate the change?

  • ui tests passing
  • BE tests passing

Release notes

Documentation Changes

@foot foot marked this pull request as ready for review November 15, 2023 14:38
@foot foot requested a review from sarataha November 15, 2023 14:38
sarataha
sarataha approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarataha sarataha sarataha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @sarataha