-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTT1 iteration 3 workflow engine unit tests #5072
DTT1 iteration 3 workflow engine unit tests #5072
Conversation
2ff97e8
to
a5a544e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, check the comments, also, please consider adding documentation to each test case about the parameters and the expected assertion case
Please provide a test usage output
deployability/modules/workflow_engine/tests/data/wf-ko-no-path-on-cleanup.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, please check the review comment
Also, we need to validate if this is expected or not
============================================================================================= short test summary info =============================================================================================
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_set_status[task1-non_existing_status-dag0] - KeyError: 'non_existing_status'
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_set_status[non_existing_task-non_existing_status-dag0] - KeyError: 'non_existing_status'
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task1-abort-related-flows-to_be_canceled1-dag0] - AssertionError: assert {'task1', 'ta...sk4', 'task5'} == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task1-abort-related-flows-to_be_canceled1-dag1] - AssertionError: assert {'task1', 'ta...sk4', 'task5'} == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task1-continue-to_be_canceled2-dag0] - assert set() == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task1-continue-to_be_canceled2-dag1] - assert set() == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task2-abort-all-to_be_canceled3-dag0] - AssertionError: assert {'task1', 'ta...sk4', 'task5'} == {'task1'}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task2-abort-all-to_be_canceled3-dag1] - AssertionError: assert {'task1', 'ta...sk4', 'task5'} == {'task1'}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task2-abort-related-flows-to_be_canceled4-dag0] - AssertionError: assert {'task1', 'ta...sk4', 'task5'} == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task2-abort-related-flows-to_be_canceled4-dag1] - AssertionError: assert {'task1', 'ta...sk4', 'task5'} == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task2-continue-to_be_canceled5-dag0] - assert set() == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task2-continue-to_be_canceled5-dag1] - assert set() == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task5-continue-to_be_canceled8-dag0] - assert set() == {}
FAILED deployability/modules/workflow_engine/tests/test_dag.py::test_cancel_dependant_tasks[task5-continue-to_be_canceled8-dag1] - assert set() == {}
========================================================================================== 14 failed, 78 passed in 0.31s ==========================================================================================
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mhamra, let's wait for the team review the pytest results
UT FAILURE UPDATEIn this commit, I adjusted all the failing test cases to pass with no failures. Please confirm the following modifications: test_cancel_dependant_tasksThe The arrows in the graph in the image indicate that task2 depends on task1, and that task5 depends on task2, task3 and task4 test_set_statusThe Unit Tests fail when the value of the status parameter is invalid (when it is not in ['failed', 'canceled', 'successful']). Should those test cases be removed, or should they be maintained? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
= 89 passed in 0.27s =
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrate commits to a new branch with origin enhancement/4495-DTT1)
ee7ccd0
to
da889f3
Compare
Related issue: #4996
Description
This PR implements the unit tests for DTT1 Workflow Engine Module