Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent feed update in the middle of the E2E Vulnerability tests #5412

Closed
1 task done
Rebits opened this issue May 22, 2024 · 3 comments · Fixed by #5424
Closed
1 task done

Prevent feed update in the middle of the E2E Vulnerability tests #5412

Rebits opened this issue May 22, 2024 · 3 comments · Fixed by #5424
Assignees
Labels

Comments

@Rebits
Copy link
Member

Rebits commented May 22, 2024

Description

It has been observed that updates to the Vulnerability Detection feed content can cause some consistency E2E tests to fail, as seen in Vulnerability detection triggers alerts for the first syscollector scan. This issue arises even when the alerts/vulnerabilities generated by the feed updates are expected. We need to investigate possible solutions to ensure consistent test outcomes.

Proposed Solutions

  • Use an Offline Feed for E2E Tests: Utilize a static version of the feed to ensure consistency across test runs.
  • Prevent Feed Updates: Increase the feed-update-interval value to prevent updates during test execution. This approach needs validation from the development team to ensure it does not affect the manager's restart process
  • Account for Feed Updates in Tests: Modify the tests to include logic that accounts for possible feed updates, ensuring expected outcomes are handled correctly.

Validation

  • Ensure that test_consistency_initial_scans passes even if a content update occurs during the tests.

Any proposed solution should be validated by: @davidjiglesias, @juliamagan

@wazuhci wazuhci moved this to Backlog in Release 4.8.0 May 22, 2024
@wazuhci wazuhci moved this from Backlog to Blocked in Release 4.8.0 May 22, 2024
@wazuhci wazuhci moved this from Blocked to Backlog in Release 4.8.0 May 23, 2024
@Rebits Rebits self-assigned this May 23, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.8.0 May 23, 2024
@Rebits
Copy link
Member Author

Rebits commented May 23, 2024

Waiting https://ci.wazuh.info/job/Test_e2e_system/ results

@wazuhci wazuhci moved this from In progress to On hold in Release 4.8.0 May 23, 2024
@wazuhci wazuhci moved this from On hold to Pending review in Release 4.8.0 May 23, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.8.0 May 24, 2024
@santipadilla
Copy link
Member

LGTM

@wazuhci wazuhci moved this from In review to Pending final review in Release 4.8.0 May 24, 2024
@davidjiglesias
Copy link
Member

LGTM

@wazuhci wazuhci moved this from Pending final review to Done in Release 4.8.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants