Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelling bug in the test_cluster_connection #4391

Closed
roronoasins opened this issue Aug 3, 2023 · 5 comments · Fixed by #4392
Closed

Fix misspelling bug in the test_cluster_connection #4391

roronoasins opened this issue Aug 3, 2023 · 5 comments · Fixed by #4392
Assignees
Labels

Comments

@roronoasins
Copy link

Description

During the research conducted in #4386, it was identified that this specific string and regex require a fix since the word successfully is misspelled.

Current behavior

pytest.fail(f'Could not find "Sucessfully connected to master" message in the '
                            f'{node_name.search(log_file)[1]}')
re.search(rb'^.*Could not connect to master. Trying.*$|^.*Sucessfully connected to master.*$',
                         s[conn.end():], flags=re.MULTILINE):

Expected behavior

pytest.fail(f'Could not find "Successfully connected to master" message in the '
                            f'{node_name.search(log_file)[1]}')
re.search(rb'^.*Could not connect to master. Trying.*$|^.*Successfully connected to master.*$',
                         s[conn.end():], flags=re.MULTILINE):
@pro-akim
Copy link
Member

pro-akim commented Aug 24, 2023

GJ!, All fixes done in the branch according.
Evidences were required in the PR

@pro-akim
Copy link
Member

pro-akim commented Aug 24, 2023

Update

Evidences were written in the issue as 'Current behavior'

@pro-akim
Copy link
Member

Update

Test run report is required
Moved to on hold

@pro-akim
Copy link
Member

Update

Report checked.
LGTM

@davidjiglesias
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants