Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables in build-images.sh #1027

Closed
kedras opened this issue Oct 5, 2023 · 1 comment
Closed

Unused variables in build-images.sh #1027

kedras opened this issue Oct 5, 2023 · 1 comment
Assignees

Comments

@kedras
Copy link

kedras commented Oct 5, 2023

Are these variables used anywhere at all now? First one is overwritten few line after and the other one seems to not be used at all since the 32b1d88. We could get off one curl call.

WAZUH_VERSION=$(echo $WAZUH_IMAGE_VERSION | sed -e 's/\.//g')

WAZUH_CURRENT_VERSION=$(curl --silent https://api.github.com/repos/wazuh/wazuh/releases/latest | grep '\"tag_name\":' | sed -E 's/.*\"([^\"]+)\".*/\1/' | cut -c 2- | sed -e 's/\.//g')

@davidcr01 davidcr01 self-assigned this Oct 9, 2023
@davidcr01
Copy link
Contributor

Hello.

Yes, these variables are no longer used anymore. These variables were used in development, and when the code is from production, these variables have the same value.

About the WAZUH_CURRENT_VERSION, it is used but defined in other files. So this variable can be removed in the build_images.sh file.

This PR removes these variables: #1025. The PR is merged into the 4.6.0 Wazuh version so that the variables will remain until this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants