Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in package build workflow #169

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Apr 18, 2024

Description

This PR fixes some problems in the package generation workflow

Issues Resolved

#167

Evidence

image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Apr 18, 2024
@Tostti Tostti linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.31%. Comparing base (f066302) to head (26a61a2).
Report is 82 commits behind head on 4.9.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##            4.9.0     #169       +/-   ##
===========================================
- Coverage   66.96%   31.31%   -35.66%     
===========================================
  Files        3300     2211     -1089     
  Lines       63585    44413    -19172     
  Branches    10141     6871     -3270     
===========================================
- Hits        42582    13909    -28673     
- Misses      18538    29884    +11346     
+ Partials     2465      620     -1845     
Flag Coverage Δ
Linux_1 31.31% <ø> (-3.92%) ⬇️
Linux_2 ?
Linux_3 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tostti Tostti merged commit 6bca359 into 4.9.0 Apr 19, 2024
66 checks passed
@Tostti Tostti deleted the 167-fix-errors-in-package-build-workflow branch April 19, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tar error in the package build workflow
3 participants