Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit SHA for all the repositories in packages name #389

Closed
Tostti opened this issue Oct 31, 2024 · 0 comments · Fixed by #390 or #420
Closed

Add commit SHA for all the repositories in packages name #389

Tostti opened this issue Oct 31, 2024 · 0 comments · Fixed by #390 or #420
Assignees
Labels
level/task Task issue mvp MVP request/operational Operational request type/enhancement New feature or request

Comments

@Tostti
Copy link
Member

Tostti commented Oct 31, 2024

Description

From Wazuh 5, wazuh-dashboard packages are composed by several components, the wazuh-dashboard and the plugins. The source code of these components are stores in different Git repositories. We need to unambiguously identify a wazuh-dashboard package, which is not the case now as the package name only contains the commit SHA from the wazuh-dashboard repo.

To ensure that changes on any of the plugins effectively identifies a package, even if the commit in the wazuh-dashboard repository is the same, we will suffix the package after the combination of the commit SHA of the 4 repositories together (wazuh-dashboard, wazuh-dashboard-plugins, wazuh-security-dashboards-plugin and wazuh-dashboard-reporting).

Use case scenario (current)

State A

Inputs: deb, x64

Repository Commit SHA
wazuh-dashboard 0fe31a0
wazuh-dashboard-plugins 4aa24f2
wazuh-security-dashboards-plugin c243585
wazuh-dashboards-reporting f09ab30

Output: wazuh-dashboard_5.0.0-1_amd64_0fe31a0.deb

State A+1

Inputs: deb, x64

Repository Commit SHA
wazuh-dashboard 0fe31a0
wazuh-dashboard-plugins e67630d
wazuh-security-dashboards-plugin c243585
wazuh-dashboards-reporting f09ab30

Output: wazuh-dashboard_5.0.0-1_amd64_0fe31a0.deb

Conclusions

Although the wazuh-dashboard-plugins repo has new code, the package is not built as there is a package in the S3 bucket suffixed with the same commit SHA.

Use case scenario (expected)

State A

Inputs: deb, x64

Repository Commit SHA
wazuh-dashboard 0fe31a0
wazuh-dashboard-plugins 4aa24f2
wazuh-security-dashboards-plugin c243585
wazuh-dashboards-reporting f09ab30

Output: wazuh-dashboard_5.0.0-1_amd64_0fe31a0-4aa24f2-c243585-f09ab30.deb

State A+1

Inputs: deb, x64

Repository Commit SHA
wazuh-dashboard 0fe31a0
wazuh-dashboard-plugins e67630d
wazuh-security-dashboards-plugin c243585
wazuh-dashboards-reporting f09ab30

Output: wazuh-dashboard_5.0.0-1_amd64_0fe31a0-e67630d-c243585-f09ab30.deb

@Tostti Tostti added type/enhancement New feature or request level/task Task issue request/operational Operational request mvp MVP labels Oct 31, 2024
@Tostti Tostti self-assigned this Oct 31, 2024
@Tostti Tostti linked a pull request Nov 1, 2024 that will close this issue
7 tasks
@yenienserrano yenienserrano linked a pull request Nov 19, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue mvp MVP request/operational Operational request type/enhancement New feature or request
Projects
None yet
1 participant