From e4a59b035b259e84af657178f5cb3ac60fef6ab8 Mon Sep 17 00:00:00 2001 From: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com> Date: Tue, 19 Nov 2024 16:33:45 +0100 Subject: [PATCH] Rename of the artifact uploaded to action (#420) --- .github/workflows/build_wazuh_dashboard_with_plugins.yml | 2 +- src/core/public/chrome/ui/header/header_logo.test.tsx | 2 +- src/core/public/chrome/ui/header/home_loader.test.tsx | 2 +- test/functional/apps/home/_home.ts | 4 ++-- test/functional/apps/visualize/_custom_branding.ts | 8 ++++---- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build_wazuh_dashboard_with_plugins.yml b/.github/workflows/build_wazuh_dashboard_with_plugins.yml index 3129f1b0e8bb..9518bfe52e4e 100644 --- a/.github/workflows/build_wazuh_dashboard_with_plugins.yml +++ b/.github/workflows/build_wazuh_dashboard_with_plugins.yml @@ -322,7 +322,7 @@ jobs: - uses: actions/upload-artifact@v3 if: success() with: - name: ${{ needs.setup-variables.outputs.PACKAGE_NAME }} + name: ${{ needs.setup-variables.outputs.FINAL_NAME }} path: ${{ needs.setup-variables.outputs.CURRENT_DIR }}/dev-tools/build-packages/output/${{needs.setup-variables.outputs.FINAL_NAME}} retention-days: 30 diff --git a/src/core/public/chrome/ui/header/header_logo.test.tsx b/src/core/public/chrome/ui/header/header_logo.test.tsx index b05c14ea5995..c43073ec7f48 100644 --- a/src/core/public/chrome/ui/header/header_logo.test.tsx +++ b/src/core/public/chrome/ui/header/header_logo.test.tsx @@ -94,7 +94,7 @@ describe('Header logo', () => { component.find('.logoContainer img').simulate('click'); expect(props.navigateToApp).toHaveBeenCalledTimes(1); - expect(props.navigateToApp).toHaveBeenCalledWith('wz-home'); + expect(props.navigateToApp).toHaveBeenCalledWith('home'); }); // ToDo: Add tests for onClick diff --git a/src/core/public/chrome/ui/header/home_loader.test.tsx b/src/core/public/chrome/ui/header/home_loader.test.tsx index 85d61dd35587..e26527cf510d 100644 --- a/src/core/public/chrome/ui/header/home_loader.test.tsx +++ b/src/core/public/chrome/ui/header/home_loader.test.tsx @@ -54,7 +54,7 @@ describe('Home loader', () => { expect(homeIcon.exists()).toBeTruthy(); homeIcon.simulate('click'); expect(props.navigateToApp).toHaveBeenCalledTimes(1); - expect(props.navigateToApp).toHaveBeenCalledWith('wz-home'); + expect(props.navigateToApp).toHaveBeenCalledWith('home'); }); }); }); diff --git a/test/functional/apps/home/_home.ts b/test/functional/apps/home/_home.ts index c75893c86b65..6c0a1a55ddb1 100644 --- a/test/functional/apps/home/_home.ts +++ b/test/functional/apps/home/_home.ts @@ -44,7 +44,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await globalNav.clickLogo(); await PageObjects.header.waitUntilLoadingHasFinished(); const url = await browser.getCurrentUrl(); - expect(url.includes('/app/wz-home')).to.be(true); + expect(url.includes('/app/home')).to.be(true); }); it('clicking on home button should take you to home page', async () => { @@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await globalNav.clickHomeButton(); await PageObjects.header.waitUntilLoadingHasFinished(); const url = await browser.getCurrentUrl(); - expect(url.includes('/app/wz-home')).to.be(true); + expect(url.includes('/app/home')).to.be(true); }); // Wazuh: The home page of Wazuh is different from the OpenSearch Dashboards home page diff --git a/test/functional/apps/visualize/_custom_branding.ts b/test/functional/apps/visualize/_custom_branding.ts index 002af7745e14..3a80fbaf45c5 100644 --- a/test/functional/apps/visualize/_custom_branding.ts +++ b/test/functional/apps/visualize/_custom_branding.ts @@ -143,7 +143,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await globalNav.clickLogo(); await PageObjects.header.waitUntilLoadingHasFinished(); const url = await browser.getCurrentUrl(); - expect(url.includes('/app/wz-home')).to.be(true); + expect(url.includes('/app/home')).to.be(true); }); it('with customized mark logo button that navigates to home page', async () => { @@ -151,7 +151,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await globalNav.clickHomeButton(); await PageObjects.header.waitUntilLoadingHasFinished(); const url = await browser.getCurrentUrl(); - expect(url.includes('/app/wz-home')).to.be(true); + expect(url.includes('/app/home')).to.be(true); }); // Wazuh: This test is omitted because OpenSearch Dashboards does not have a home dashboard card. @@ -211,7 +211,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await globalNav.clickLogo(); await PageObjects.header.waitUntilLoadingHasFinished(); const url = await browser.getCurrentUrl(); - expect(url.includes('/app/wz-home')).to.be(true); + expect(url.includes('/app/home')).to.be(true); }); it('with customized mark logo button that navigates to home page', async () => { @@ -219,7 +219,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await globalNav.clickHomeButton(); await PageObjects.header.waitUntilLoadingHasFinished(); const url = await browser.getCurrentUrl(); - expect(url.includes('/app/wz-home')).to.be(true); + expect(url.includes('/app/home')).to.be(true); }); // Wazuh: This test is omitted because OpenSearch Dashboards does not have a home dashboard card.