Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer md5 hash incorrect (multiple releases) #976

Closed
justusbunsi opened this issue Aug 9, 2023 · 3 comments
Closed

Windows installer md5 hash incorrect (multiple releases) #976

justusbunsi opened this issue Aug 9, 2023 · 3 comments
Assignees
Labels
reporter/community Issue reported by the community

Comments

@justusbunsi
Copy link

justusbunsi commented Aug 9, 2023

Hi, the referenced md5 checksum for windows installer on tags v4.4.5 and v4.5.0 does not match the currently downloadable installer.

v4.4.5

Reference in release: a03806b7302767d0470d65d3f103fabb (which matches the one from v4.4.4)
Actual checksum (as of 2023-08-09): 396833b72a865be4b693f18ee2e34cde

image

v4.5.0

Reference in release: a03806b7302767d0470d65d3f103fabb (still which matches the one from v4.4.4)
Actual checksum (as of 2023-08-16): fd53c0afc26394ef5ce6a0922186de29

image

As it seem to be a reoccurring issue, is there anything missing in the release workflow? (see #928)

@justusbunsi justusbunsi changed the title v4.4.5: Windows installer md5 hash incorrect Windows installer md5 hash incorrect (multiple releases) Aug 16, 2023
@davidcr01 davidcr01 self-assigned this Aug 22, 2023
@davidcr01 davidcr01 added the reporter/community Issue reported by the community label Aug 22, 2023
@davidcr01
Copy link
Contributor

Hello.

Two PRs have been created to fix this problem:

This mistake is done because is necessary to check the MD5 checksums after the packages are generated, and then, change them before releasing the definitive tag.

Hope it helps.
Regards, David.

@justusbunsi
Copy link
Author

Thanks for fixing the releases. I can confirm that it now works.

@davidcr01 anything I can help with, so that the mistake doesn't happen in the future again?

@davidcr01
Copy link
Contributor

Thanks, but no further help from you is needed. If your problem is fixed, I assume I can close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporter/community Issue reported by the community
Projects
None yet
Development

No branches or pull requests

3 participants