Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ansible_facts to reference facts #891

Closed
wants to merge 26 commits into from

Conversation

GregWhiteyBialas
Copy link

By default, Ansible injects a variable for every fact, prefixed with
ansible_. This can result in a large number of variables for each host,
which at scale can incur a performance penalty. Ansible provides a
configuration option [0] that can be set to False to prevent this
injection of facts. In this case, facts should be referenced via
ansible_facts.<fact>.

This change updates all references to Ansible facts from using
individual fact variables to using the items in the
ansible_facts dictionary. This allows users to disable fact variable
injection in their Ansible configuration, which may provide some
performance improvement.

[0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars

teddytpc1 and others added 26 commits May 20, 2022 15:03
Fix to be able to set complex passwords with symbols too
…o-glibc-tomaster

Add fix to avoid GLIBC crash
markgoddard
markgoddard previously approved these changes Feb 16, 2023
@teddytpc1 teddytpc1 self-assigned this Mar 10, 2023
@teddytpc1
Copy link
Member

I have tested the changes and they are working fine:
Screenshot from 2023-03-10 16-15-35
I will need a new PR with a new branch from 4.4 and 4.4 as the base branch, please.

@GregWhiteyBialas GregWhiteyBialas changed the base branch from master to 4.4 March 14, 2023 15:18
@GregWhiteyBialas GregWhiteyBialas dismissed markgoddard’s stale review March 14, 2023 15:18

The base branch was changed.

@GregWhiteyBialas
Copy link
Author

Hi. New PR: #893
If something is wrong with it let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails when sensible option inject_facts_as_vars = False
8 participants