Runtime failures during 'strict mode' #52
Comments
psybuzz
added a commit
to tensorflow/tensorboard
that referenced
this issue
Aug 5, 2020
Projector depends on Weblas, a 3rd party dependency that throws runtime errors when run in a browser's strict mode: waylonflinn/weblas#52 To workaround the error, this changes our Rollup config to generate output files in non-strict mode. Manually checked that the standalone target now works (errored with `p is not defined` before): `blaze run tensorboard/plugins/projector/polymer3/vz_projector:standalone`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running weblas in a browser's 'strict mode' will throw runtime errors.
Repro: see https://jsfiddle.net/u7by8azp/, created by pasting dist/weblas.js into a script with 'use strict' at the top.
Expected: no console errors in devtools
Actual:
This makes it challenging to use weblas as an external dependency when building a project that bundles or concatenates it with other scripts that have strict mode enabled.
It seems that if we patch a couple instances in weblas code, adding
varbefore variable declarations, this should work:https://jsfiddle.net/cft3aqvu/
The text was updated successfully, but these errors were encountered: