Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize this Project for Easier Contribution #740

Open
sujal-goswami opened this issue Jul 30, 2024 · 5 comments · May be fixed by #767
Open

Containerize this Project for Easier Contribution #740

sujal-goswami opened this issue Jul 30, 2024 · 5 comments · May be fixed by #767
Labels
good first issue Good for newcomers legacy Issue pertaining to WaveLegacy

Comments

@sujal-goswami
Copy link

Is your feature request related to a problem? Please describe.
I'm always frustrated when trying to set up the development environment for this project. The process can be time-consuming and error-prone, particularly when dealing with different dependencies and system configurations.

Describe the solution you'd like
I propose containerizing this project using Docker. By providing a pre-configured Docker container, developers can quickly and easily set up a consistent development environment. This would streamline the onboarding process for new contributors and ensure that everyone is working with the same setup, reducing the likelihood of environment-related issues.

@esimkowitz esimkowitz added the good first issue Good for newcomers label Aug 16, 2024
@esimkowitz
Copy link
Member

Good idea, our dependencies are pretty straightforward if you want to give it a go!

@sujal-goswami
Copy link
Author

I have given it a try, but unfortunately, it resulted in some unusual errors. Could you please take a look at it?

image
image
image
image

@esimkowitz
Copy link
Member

esimkowitz commented Aug 19, 2024

Wavesrv depends on waveshell, so you can't copy just wavesrv when creating the wavesrv-builder stage. It looks like you copied both for the waveshell-builder instead of for the wavesrv-builder.

I would recommend running all the go builds as a monolithic backend-builder stage

@sujal-goswami
Copy link
Author

Hey, during my local build, I discovered some issue in build-linux.md in there npm install -g yarn is installing other version of yarn but this project uses version "[email protected]" which causing problem.
image

but even after resolving it during running client, it gives a strange error
image

@esimkowitz
Copy link
Member

esimkowitz commented Aug 24, 2024

Ah, it looks like our documentation in the build-linux document is out of date, we use Yarn Modern for our package manager, which requires some extra setup. Check out the info in the macOS instructions regarding Yarn: https://github.com/wavetermdev/waveterm/blob/main/BUILD.md#prereqs-and-tools

Specifically, you need to run the following:

corepack enable
yarn install

@esimkowitz esimkowitz added the legacy Issue pertaining to WaveLegacy label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers legacy Issue pertaining to WaveLegacy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants