-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage failing on Master ? #36
Comments
$
|
Actually the coverage is an old thing (there wasn't even babel at that time) that we didn't maintain since a long time. I will probably remove that in the next release. As for the test themselves, I guess we didn't take time to maintain them as we should have... so some of them are probably outdated. |
Bummer :(
This library is fantastic. Not sure people realize the wealth of
information here.
I’d love to work on getting test coverage setup for more modern tools.
I really appreciate the feedback. I’ll continue to help wherever I can.
…On Tue, Nov 14, 2017 at 1:32 PM Benjamin Matuszewski < ***@***.***> wrote:
Actually the coverage is an old thing (there wasn't even babel at that
time) that we didn't maintain since a long time. I will probably remove
that in the next release.
As for the test themselves, I guess we didn't take time to maintain them
as we should have... so some of them are probably outdated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABEPJQYP4_ROyGJijZWSiaQyFPzIK-iDks5s2dyhgaJpZM4QdsBl>
.
|
Hey guys, I'm noticing a bunch of failing tests on
master
. Is this known? I was hoping to try and get a test to fail for the odd segment drag behavior I'm seeing but I'm a total newb when it comes to writing JS tests using browserify, testling, babel-tape-runner, etc.Also, I really want to be working off the
develop
branch and the tests don't seem to be running at all??I'm seeing the following differences in the
package.json
scriptsMASTER BRANCH
DEVELOP BRANCH
The coverage command seems to have been killed in the develop branch. The test command in develop doesn't print anything.
Also, all the tests in the develop branch still include from the
es6
directory which doesn't exist.import AnnotatedMarkerLayer from '../es6/helpers/annotated-marker-layer';
$ MASTER BRANCH
yarn coverage
output belowThe text was updated successfully, but these errors were encountered: