Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water body material override #902

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

huwb
Copy link
Contributor

@huwb huwb commented Sep 11, 2021

Status: Ready for review

In response to a support request - add a material override field to water bodies. Seems to work fairly straightforwardly (IMO).

@huwb huwb requested a review from daleeidd September 11, 2021 14:10
@daleeidd
Copy link
Collaborator

Works great. Nice and simple. Should the OceanMaterial return the water body override material for the underwater renderer etc?

@huwb
Copy link
Contributor Author

huwb commented Sep 11, 2021

Ha yeah good point. It's not clear to me at all how it will work for underwater. I would guess the underwater effect should search all water bodies and find any overrides, as a separate process. Or it should do something else entirely. But if you have an idea for a simple way it can be done (I wasnt sure if i understood if OceanMaterial can help) then let me know.

If its going to be an entirely separate thing im tempted to call it future work and see if it is requested in practice. But lmk what you think!

EDIT: Oh if you meant OceanMaterial should return an ymaterial from any overlapping water bodies under the camera, it could, but all tiles check this material and assign it to themselves so its not clear to me if this works

@daleeidd
Copy link
Collaborator

Yeah, you're right. Separate process or something in the future sounds good.

@huwb
Copy link
Contributor Author

huwb commented Sep 11, 2021

Ok cool. I've updated the status from 'experimental' to ready for review as i think this could merge

@huwb
Copy link
Contributor Author

huwb commented Sep 11, 2021

Oh release notes. Oops.

@huwb
Copy link
Contributor Author

huwb commented Sep 11, 2021

Added release notes and some misc doc stuff

Copy link
Collaborator

@daleeidd daleeidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

@daleeidd daleeidd added this to the 4.14 milestone Sep 15, 2021
@huwb
Copy link
Contributor Author

huwb commented Sep 15, 2021

Cheers

@huwb huwb merged commit 343830a into master Sep 15, 2021
@huwb huwb deleted the feature/water-body-material-override branch September 15, 2021 06:27
@huwb huwb mentioned this pull request Sep 15, 2021
8 tasks
@daleeidd
Copy link
Collaborator

daleeidd commented Nov 4, 2021

Linking #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants