Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy executable should not require flakes or nix-command features #39

Open
water-sucks opened this issue Aug 19, 2024 · 1 comment · May be fixed by #50
Open

legacy executable should not require flakes or nix-command features #39

water-sucks opened this issue Aug 19, 2024 · 1 comment · May be fixed by #50
Assignees
Labels
bug Something isn't working legacy This is related to the legacy executable

Comments

@water-sucks
Copy link
Owner

What Happened?

The flakes features are required in order to fetch and use the Nix package properly, due to its reliance on builtins.getFlake. This is due to the fact that package.nix relies on a fetchZigDeps function that comes from a flake.

Refactor the flake and package such that anyone can reliably use callPackage themselves on the Nix file without having to provide any parameters themselves.

Additionally, review usage of the nix command using the runCmd function and make sure that legacy commands use the nix-* equivalent forms of the commands, to avoid requiring the nix-command interface. It could be the case that there are no usages of nix-command in legacy-style code, in which case we can ignore this, but this is something that needs to be audited properly.

How To Reproduce

Attempt to use this flake in legacy configurations.

Expected Behavior

I expected to be able to use this executable without enabling the flakes and nix-command experimental features.

Features

(not relevant)
@water-sucks water-sucks added bug Something isn't working legacy This is related to the legacy executable labels Aug 19, 2024
@water-sucks water-sucks self-assigned this Aug 20, 2024
@water-sucks
Copy link
Owner Author

The rewrite will fix this due to fetchZigDeps not being present. A simple import of the default.nix should suffice after this.

@water-sucks water-sucks linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working legacy This is related to the legacy executable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant