Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically apply an annotation so that Wadm and KubeVela do not conflict #11

Open
protochron opened this issue Apr 2, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@protochron
Copy link
Contributor

KubeVela is the originating project for the OAM manifest spec and is one if not the primary consumer of OAM applications in a Kubernetes cluster. A KubeVela controller will try and manage a wasmCloud application if its informer is triggered without any sort of intervention. We might get lucky in the sense that wasmCloud applications are not actually CRDs stored in Kubernetes but are relayed through the aggregated API.

KubeVela uses an annotation app.oam.dev/controller-version-require which will short-circuit KubeVela's controller if the version does not match what the controller expects. We can simply set app.oam.dev/controller-version-require: wadm and that would take care of any conflicts. The operator should automatically append this annotation when relaying the manifest through Kubernetes APIs just in case changes to a manifest driven by Kubernetes were cause a reconciliation in the KubeVela controller.

It is probably unlikely that someone would try and run KubeVela and wasmCloud in the same cluster, but this is a straightforward way to ensure that they do not conflict.

@protochron protochron added the good first issue Good for newcomers label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant